Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] product_contract #1006

Closed
wants to merge 155 commits into from
Closed

[16.0][MIG] product_contract #1006

wants to merge 155 commits into from

Conversation

mileo
Copy link
Member

@mileo mileo commented Oct 13, 2023

Replace: #959

Ted Salmon and others added 30 commits April 29, 2023 22:42
@Rad0van
[ADD] product_contract: Create module
df3e3f3 
* Add contract functionality to `product.templates`
* Add logic to create contracts from `sale.order` that contains contract products.
@lasley @Rad0van
[FIX] product_contract: Fix mock usage in tests
be53fcd
@flotho @Rad0van
[FIX] contract_sale_generation: it doesn't create sales (OCA#141)
781f51d 
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
@sbejaoui @Rad0van
[MIG] - Product Contract Migration to 12.0
9dd2907
@sbejaoui @Rad0van
[IMP] - Product with is_contract can be only of type service
bff365d
@sbejaoui @Rad0van
[IMP] - Change dependencies to contract_sale
d678fa7
@sbejaoui @Rad0van
[IMP] - Add recurrence fields to product template and sale order line
1f0c4af
@sbejaoui @Rad0van
[IMP] - Create contract on sale order confirmation
aba4baa 
- On Sale Order confirmation, a contract is created for each contract template used on sale order lines
- A not finished contract can be mentioned on sale order line
- A sale order line linked to a contract will update it and don't create a new one if it had the same template
@sbejaoui @Rad0van
[IMP] - Link contract line to sale order line
1f9d3fd
@sbejaoui @Rad0van
[FIX] - Remove recurring_next_date from sale order line
20db377 
recurring_next_date should be computed by contract line to get default value
@sbejaoui @Rad0van
[IMP] - Contract product are ignored on invoicing process
2b31fa7 
- Sale order line for contract product pass to nothing to invoice on order confirmation
- Contract Invoices are linked to sale order line
@sbejaoui @Rad0van
[FIX] - Default value for date_start applied on product change
c321bf6
@sbejaoui @Rad0van
[ADD] - Add readme directory
c5ffb71
@sbejaoui @Rad0van
[IMP] - Onchange contract product on contract contract and contract t…
6780081 
…emplate
@sbejaoui @Rad0van
[FIX] - Change website to OCA repository url and prefix module name w…
0519d94 
…ith Recurring
@sbejaoui @Rad0van
[FIX] - Compute recurring_next_date before create contract line
b9890cf
@sbejaoui @Rad0van
[IMP] - Upsell/Downsell contract from sale order
3cf2443
@sbejaoui @Rad0van
[ADD] - Add renewal process with termination notice
8ee7f71
@sbejaoui @Rad0van
[IMP] - compute date end onchange date start for auto-renew sale orde…
6c39a13 
…r lines
@sbejaoui @Rad0van
[IMP] - link contract line and its successor in upsel case
755923f
@sbejaoui @Rad0van
[FIX] - on upsel, contract line should stop day - 1
91cd66b
@sbejaoui @Rad0van
[FIX] - fix onchange
bb7800a
@sbejaoui @Rad0van
[IMP] - hide recurring_invoicing_type if recurring_rule_type is month…
d54b77c 
…lylastday

for the monthlylastday case, pre-paid is logicly impossible,
if monthlylastday is set, we consider only post-paid case
@sbejaoui @Rad0van
[FIX] - include date_end in the period if the product is_autorenew
7bc929e
@sbejaoui @Rad0van
[IMP] - _prepare_contract_value for sale order confirm
ae9a160
@sbejaoui @Rad0van
[REM] - Remove unused method
401f859
@sbejaoui @Rad0van
[IMP] - get contract user from sale order user
c8d9ee5
@sbejaoui @Rad0van
[IMP] - show related sale orders in contract form
15728df
@ThomasBinsfeld @Rad0van
[REF] Contract Product: invoice in prepare_invoice_line is optional
19a3294
@sbejaoui @Rad0van
[FIX] - fix flake8
c25f345
fcolus and others added 23 commits April 29, 2023 22:42
@fcolus @Rad0van
Translated using Weblate (Portuguese (Brazil))
d6fbd5b 
Currently translated at 100.0% (49 of 49 strings)

Translation: contract-12.0/contract-12.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract/pt_BR/
@oca-transbot @Rad0van
Update translation files
dc1adb8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-12.0/contract-12.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract/
@gregory-moka @Rad0van
Translated using Weblate (French)
8c660cf 
Currently translated at 100.0% (49 of 49 strings)

Translation: contract-12.0/contract-12.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-product_contract/fr/
@sbejaoui @Rad0van
[13.0][MIG] - migration product_contract
fd03a6b
@mourad-ehm @Rad0van
[IMP] product_contract: black, isort, prettier
f1ad5c1
@mourad-ehm @Rad0van
[MIG] product_contract: Migration to 14.0
dcfa32a
@ilyasProgrammer @Rad0van
[IMP] product_contract: use _compute_display_name. Moved it to contra…
a0b32b5 
…ct module.
@ilyasProgrammer @Rad0van
[IMP] product_contract: code improvements
cb6a58e
@Rad0van
[UPD] Update product_contract.pot
42d34ec
@OCA-git-bot @Rad0van
[UPD] README.rst
9ba7766
@OCA-git-bot @Rad0van
product_contract 14.0.1.0.1
9d8e290
@francesco-ooops @Rad0van
Translated using Weblate (Italian)
32fd56e 
Currently translated at 100.0% (49 of 49 strings)

Translation: contract-14.0/contract-14.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-product_contract/it/
@mymage @Rad0van
Translated using Weblate (Italian)
c5924a0 
Currently translated at 100.0% (49 of 49 strings)

Translation: contract-14.0/contract-14.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-product_contract/it/
@francesco-ooops @Rad0van
Translated using Weblate (Italian)
9df3ea4 
Currently translated at 100.0% (49 of 49 strings)

Translation: contract-14.0/contract-14.0-product_contract
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-product_contract/it/
@Rad0van
[IMP] product_contract: pre-commit stuff
cb47543
@Rad0van
[MIG] product_contract: Migration to 16.0
54fad5f
@Rad0van
first batch of proposed changes
dc58420
@Rad0van
Command fix
68dd646
@Rad0van
Use compute methods to update recurrence fields
c4c54b7
@Rad0van
Use compute methods to update recurrence fields - fix
7b579c4
@Rad0van
pylint compliance
32ab6b3
Merge commit 'refs/pull/959/head' of https://github.com/oca/contract …
563d609 
…into 16.0-mig-product_contract
@mileo
[FIX] invisible product_contract fields
48c3f39
@bvanjeelharia
Copy link

Hey @mileo ,

Currently,ff contract template is not defined on contract products, it throws an error ("You must specify a contract template for") when a sale order is being confirmed. So , can you make it mandatory at the product level to specify contract template for contract products as otherwise users making a purchase of contract products on the website would run into this issue as can be seen in the screenshot after they have made the payment.
Screenshot from 2023-10-16 14-15-06

Thanks

Manuel-Dellisse added a commit to ACCOMODATA-BVBA/contract that referenced this pull request Oct 18, 2023
@Manuel-Dellisse
Merge remote-tracking branch 'kmee/16.0-mig-product_contract' into 16…
a1e905d 
….0-mig

OCA#1006
@Rad0van
Copy link
Contributor

Rad0van commented Nov 9, 2023

Replace: #959

Can you tell the reason?

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 10, 2024
@pedrobaeza
Copy link
Member

As #959 is green and previous to this one, I close it.

@pedrobaeza pedrobaeza closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.