Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP]subscription_oca: enable additional filters for sale.subscription #1035

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[14.0][IMP]subscription_oca: enable additional filters for sale.subscription #1035

merged 1 commit into from
Jan 15, 2024

Conversation

PicchiSeba
Copy link

Adds additional filters to the search view for sale.subscription. Inspired by those for model contract.contract

@OCA-git-bot
Copy link
Contributor

Hi @ilyasProgrammer,
some modules you are maintaining are being modified, check this out!

@PicchiSeba PicchiSeba force-pushed the 14.0-subscription_oca-improve-filter branch 3 times, most recently from 8554d99 to 53bb850 Compare January 12, 2024 12:07
@PicchiSeba
Copy link
Author

Ready for review

francesco-ooops
francesco-ooops approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aleuffre
aleuffre suggested changes Jan 15, 2024
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: functionality seems ok, just some code cleanup

subscription_oca/views/sale_subscription_views.xml Outdated Show resolved Hide resolved
subscription_oca/views/sale_subscription_views.xml Outdated Show resolved Hide resolved
subscription_oca/views/sale_subscription_views.xml Outdated Show resolved Hide resolved
@PicchiSeba PicchiSeba force-pushed the 14.0-subscription_oca-improve-filter branch from 53bb850 to e0686cb Compare January 15, 2024 13:35
aleuffre
aleuffre approved these changes Jan 15, 2024
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

subscription_oca/views/sale_subscription_views.xml Show resolved Hide resolved
@PicchiSeba PicchiSeba force-pushed the 14.0-subscription_oca-improve-filter branch from e0686cb to 7092694 Compare January 15, 2024 13:41
@aleuffre
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1035-by-aleuffre-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f2649c3 into OCA:14.0 Jan 15, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 64fb5c0. Thanks a lot for contributing to OCA. ❤️

@aleuffre aleuffre deleted the 14.0-subscription_oca-improve-filter branch January 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PicchiSeba @OCA-git-bot @aleuffre @francesco-ooops