Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] subscription_oca: more invoicing modes #1037

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[14.0][IMP] subscription_oca: more invoicing modes #1037

merged 1 commit into from
Jan 26, 2024

Conversation

ilyasProgrammer
Copy link
Member

@ilyasProgrammer ilyasProgrammer commented Jan 14, 2024 •
edited
Loading

New modes to generate SO and Invoce:

        ("sale_and_invoice_draft", "Sale order & Invoice Draft"),
        ("sale_and_invoice_send", "Sale Order & Invoice Send"),
        ("sale_draft", "Sale Order Draft"),
        ("sale_confirmed", "Sale Order Confirmed"),

@OCA-git-bot
Copy link
Contributor

Hi @PicchiSeba, @renda-dev, @aleuffre,
some modules you are maintaining are being modified, check this out!

@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-subscription_oca-more-conditions branch from 63a18f2 to a41e59c Compare January 21, 2024 11:05
@rousseldenis rousseldenis added this to the 14.0 milestone Jan 22, 2024
@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-subscription_oca-more-conditions branch 5 times, most recently from 069c081 to 0c619c8 Compare January 23, 2024 05:54
@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-subscription_oca-more-conditions branch from bcac3a3 to c7d311e Compare January 24, 2024 12:23
francesco-ooops
francesco-ooops approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

aleuffre
aleuffre approved these changes Jan 26, 2024
View reviewed changes
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@aleuffre
Copy link

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1037-by-aleuffre-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 4e7d537 into OCA:14.0 Jan 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at caa057b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisandrewmann chrisandrewmann chrisandrewmann left review comments

@aleuffre aleuffre aleuffre approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ilyasProgrammer @OCA-git-bot @aleuffre @chrisandrewmann @francesco-ooops @rousseldenis