[16.0][IMP] contract: Protect line recurrrency change #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have defined several contract lines, each one with their recurrency information, unmarking the check "Line recurrency" by mistake and saving will make you lose the configuration in one shot, and also modify the invoceability conditions. Thus, it's reasonable to avoid to uncheck the mark once you have at least one invoice issued for a contract with this mark checked. TT47015
pedrobaeza
requested review from
carlosdauden and
carolinafernandez-tecnativa
pedrobaeza
changed the title
victoralmau
approved these changes
Feb 15, 2024
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8436099. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-imp-contract-avoid_line_recurrency_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #1033
If you have defined several contract lines, each one with their recurrency information, unmarking the check "Line recurrency" by mistake and saving will make you lose the configuration in one shot, and also modify the invoceability conditions.
Thus, it's reasonable to avoid to uncheck the mark once you have at least one invoice issued for a contract with this mark checked.
@Tecnativa