[17.0][FIX] product_contract: Compute date_start and date_end correctly. Make fields computed #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbejaoui, |
sergio-teruel
force-pushed
the
17.0-FIX-product_contract-compute-dates
branch
2 times, most recently
from
a3b606d to
90dcd82
Compare
CarlosRoca13
approved these changes
Jan 27, 2025
CarlosRoca13
suggested changes
Jan 27, 2025
sergio-teruel
force-pushed
the
17.0-FIX-product_contract-compute-dates
branch
2 times, most recently
from
6c26639 to
111b506
Compare
CarlosRoca13
approved these changes
Jan 27, 2025
sergio-teruel
force-pushed
the
17.0-FIX-product_contract-compute-dates
branch
2 times, most recently
from
cb44b22 to
ffa3e67
Compare
carlos-lopez-tecnativa
suggested changes
Jan 27, 2025
| ) | ||
| ).replace(day=1) - relativedelta(days=1) | ||
| elif sol.contract_start_date_method == "start_next": | ||
| # Dia 1 del siguiente recurring_rule_type |
There was a problem hiding this comment.
Could you please avoid spanglish?
| def _get_auto_renew_rule_type(self): | ||
| """monthly last day don't make sense for auto_renew_rule_type""" | ||
| self.ensure_one() | ||
| if self.recurring_rule_type == "monthlylastday": | ||
| if self.auto_renew_rule_type == "monthlylastday": |
There was a problem hiding this comment.
Why did you change the field?
I see this field cannot have the option monthlylastday
contract/product_contract/models/sale_order_line.py
Lines 68 to 74 in 4f6bd60
…ke fields computed
… to use them on _compute_name method
CarlosRoca13
force-pushed
the
17.0-FIX-product_contract-compute-dates
branch
from
4f6bd60 to
76d8c2f
Compare
|
@carlos-lopez-tecnativa Changes done! |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 4cbc960. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT54646
ping @CarlosRoca13 @carlos-lopez-tecnativa