Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] contract: Invoice creation message translatable #1189

Merged

Conversation

pedrobaeza
Copy link
Member

As it was, the text to translate is not correctly extracted, so it's not translated, creating a mix of languages, as _creation_message is returning a translated sentence.

We take also the opportunity to change the way the sentence is built for having as translatable only the "by contract" words, to avoid possible errors in translations due to the placeholders.

Before:
imagen

After:
imagen

@Tecnativa

As it was, the text to translate is not correctly extracted, so it's
not translated, creating a mix of languages, as `_creation_message`
is returning a translated sentence.

We take also the opportunity to change the way the sentence is built
for having as translatable only the "by contract" words, to avoid
possible errors in translations due to the placeholders.
@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 1, 2025
@pedrobaeza
Copy link
Member Author

Fast-tracking as obvious bug:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1189-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-1189-by-pedrobaeza-bump-patch:16.0 failed with output:

To https://github.com/OCA/contract
 ! [rejected]          16.0-ocabot-merge-pr-1189-by-pedrobaeza-bump-patch -> 16.0 (fetch first)
error: failed to push some refs to 'https://github.com/OCA/contract'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 96c658b into OCA:16.0 Feb 1, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f45e8af. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-contract-invoice_creation_message branch February 1, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants