[15.0][ADD] contract_sale_generation_merge: New module contract_sale_generation_merge #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppyczko
force-pushed
the
15.0-add-contract_sale_generation_merge
branch
from
fc0c764 to
cd434cc
Compare
BernatObrador
approved these changes
Feb 18, 2025
| self._add_contract_lines(existing_sale) | ||
| sale_orders |= existing_sale | ||
| else: | ||
| sale_orders |= self.env["sale.order"].create(sale_values) |
There was a problem hiding this comment.
You can create a list of sale values and call create() once instead.
ppyczko
force-pushed
the
15.0-add-contract_sale_generation_merge
branch
from
cd434cc to
b21ed36
Compare
lbarry-apsl
approved these changes
Feb 20, 2025
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module extends contract sale generation by merging contract lines into an existing sale order within the same commitment (delivery) date.
cc https://github.com/APSL 166288
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review