[18.0][MIG] Migration of subscription_oca to 18.0 #1304

tarteo · 2025-09-17T12:05:21Z

Continuation of: #1209

Includes:

Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Currently translated at 92.6% (151 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/fi/

Currently translated at 58.8% (96 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

Currently translated at 61.3% (100 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/ca/

chrisandrewmann · 2025-09-19T10:56:04Z

@chrisandrewmann I've fixed the kanban and added currency to the list view

Thanks @tarteo, just checked and mostly sorted but one place the currency still shows as missing.

tarteo · 2025-09-19T11:24:22Z

@chrisandrewmann Fixed! :)

ivilata · 2025-09-25T08:20:51Z

Thanks @tarteo for the PR (and @chrisandrewmann for the testing)! Does this PR also supersede #1245?

tarteo · 2025-09-25T10:31:04Z

@ivilata Yes

ivilata

Thanks @tarteo for the PR! It looks good to me, and I found no issues with manual testing on Runboat.

@chrisandrewmann, if you're also happy with the adaptation, you may want to create a proper positive review so that we can unlock the merging process. Thanks!

chrisandrewmann

Amazing. Looks good to me, did a quick test of a new subscription, triggered the scheduler to generate invoice and then closed subscription.

OCA-git-bot · 2025-09-29T09:06:39Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2025-09-29T09:06:42Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivilata · 2025-10-02T09:51:43Z

@rousseldenis, if the PR looks good to you, would you mind accepting it for meging?

Thanks a lot! 🙂

chrisandrewmann · 2025-10-08T16:17:26Z

@tarteo I found a small issue if you have time to fix it?

The messages posted to chatter in sale_subscription.py look like this:

The solution is 2 lines of code below, works for me.

Line 7: from markupsafe import Markup
Line 364: self.message_post(body=Markup(message_body))

tarteo · 2025-10-09T11:28:08Z

@chrisandrewmann Yes, I fixed it! 😄

chrisandrewmann · 2025-10-14T22:28:01Z

@carlos-domatix @carolina-domatix could you please approve to merge this?

I have a new PR i'd like to submit which adds automated payments via payment tokens to subscription_oca, something I feel is crucially important for many.

carlos-domatix

LGTM, but I don’t have permissions to merge. @rousseldenis could you please review it when you have a moment?

rousseldenis · 2025-10-15T06:54:48Z

subscription_oca/__manifest__.py

    "website": "https://github.com/OCA/contract",
    "license": "AGPL-3",
-    "author": "Domatix, Odoo Community Association (OCA)",
+    "author": "Domatix, Onestein, Odoo Community Association (OCA)",


@tarteo Are you really author? Migration does not mean necessarily you become one.

See previous PRs on this module. We've put alot of time in this module...

#1058

rousseldenis · 2025-10-15T06:56:19Z

Includes:

Apply changes of #1058

Apply changes of #1224

Apply changes of #1210

Apply changes of #1167

@tarteo I don't see the corresponding commits here

rousseldenis · 2025-10-15T06:57:10Z

Continuation of: #1209

It is fair to keep original migration commits

tarteo · 2025-10-15T09:42:19Z

@rousseldenis I had to reopen the PR because I did something bad while rebasing, then I just created a separate branch as all commits must be rebased into one commit anyways.

tarteo · 2025-10-15T09:55:31Z

I will not waste anymore time on this, accept it as is or close the PR. If you want to change anything create a new PR copy the changes and merge that with "ACSONE" as author I don't really care...

ivs-cetmix · 2025-10-16T18:37:49Z

@tarteo thank you for your contribution! @rousseldenis what are the acceptance criterias for having this merged? Pick all the commits from #1209 and put them in this branch? Are they really needed for the module to work?

chrisandrewmann · 2025-10-24T11:18:16Z

Thanks for all your work @tarteo
I would also be keen to see this merged ASAP @rousseldenis
It's holding up a PR i'd like to make for further improvements as mentioned above (adding automatic payments).

ivs-cetmix · 2025-10-24T11:42:53Z

@chrisandrewmann let's wait until next the week. It there is no feedback please ping me, I will merge it as is.

ivs-cetmix · 2025-10-30T11:13:51Z

Hi @rousseldenis would appreciate you looking into this. Would be great to have it merged.

carlos-domatix and others added 30 commits September 17, 2025 14:02

[15.0][ADD] subscription_oca

096a69b

[IMP] subscription_oca: tests

6067fcc

[IMP] subscription_oca: refactoring

7e7cc06

Added translation using Weblate (Spanish)

81dac6c

[MIG] subscription_oca: Migration to 16.0

5440a93

[IMP] subscription_oca: tests

4d1d148

[IMP] subscription_oca: tests adjustments

d1843ae

[UPD] Update subscription_oca.pot

1cd57d6

[BOT] post-merge updates

7f1d580

Added translation using Weblate (French)

b7c8a8d

Added translation using Weblate (Dutch)

d81ef51

Translated using Weblate (Dutch)

e9fa014

Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/

Added translation using Weblate (Italian)

f70b8e3

[IMP] subscription_oca: pre-commit auto fixes

ed32eff

[MIG] subscription_oca: Migration to 17.0

a2e9860

[UPD] Update subscription_oca.pot

564e0d1

[BOT] post-merge updates

943229b

Update translation files

7eb8fb1

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Translated using Weblate (Italian)

9d0eb4e

Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Added translation using Weblate (Finnish)

e988a68

Translated using Weblate (Finnish)

6496831

Currently translated at 92.6% (151 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/fi/

Added translation using Weblate (Turkish)

ac8e53f

Translated using Weblate (Turkish)

4f74236

Currently translated at 58.8% (96 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

Translated using Weblate (Turkish)

b798cfc

Currently translated at 61.3% (100 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

[UPD] Update subscription_oca.pot

88f3426

Update translation files

18a5492

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Translated using Weblate (Italian)

b0eac54

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Translated using Weblate (Turkish)

70fe8b3

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/tr/

Added translation using Weblate (Catalan)

f36e8cb

Translated using Weblate (Catalan)

0cb7277

Currently translated at 100.0% (164 of 164 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/ca/

tarteo force-pushed the 18-mig-subscription branch from f80b2b2 to 9cbf302 Compare September 19, 2025 11:23

tarteo force-pushed the 18-mig-subscription branch from 9cbf302 to b2f98fb Compare September 19, 2025 11:26

ivilata approved these changes Sep 29, 2025

View reviewed changes

chrisandrewmann approved these changes Sep 29, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Sep 29, 2025

[MIG] subscription: Migration to 18.0

d182208

tarteo force-pushed the 18-mig-subscription branch from b2f98fb to d182208 Compare October 9, 2025 11:27

carlos-domatix approved these changes Oct 15, 2025

View reviewed changes

rousseldenis reviewed Oct 15, 2025

View reviewed changes

tarteo mentioned this pull request Oct 15, 2025

[18.0][MIG] Migration of subscription_oca to 18.0 #1245

Closed

adasatorres approved these changes Oct 30, 2025

View reviewed changes

Uh oh!

[18.0][MIG] Migration of subscription_oca to 18.0 #1304

Are you sure you want to change the base?

[18.0][MIG] Migration of subscription_oca to 18.0 #1304

Uh oh!

Conversation

tarteo commented Sep 17, 2025

Uh oh!

chrisandrewmann commented Sep 19, 2025

Uh oh!

tarteo commented Sep 19, 2025

Uh oh!

ivilata commented Sep 25, 2025

Uh oh!

tarteo commented Sep 25, 2025

Uh oh!

ivilata left a comment

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Sep 29, 2025

Uh oh!

OCA-git-bot commented Sep 29, 2025

Uh oh!

ivilata commented Oct 2, 2025

Uh oh!

chrisandrewmann commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarteo commented Oct 9, 2025

Uh oh!

chrisandrewmann commented Oct 14, 2025

Uh oh!

carlos-domatix left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rousseldenis Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

tarteo Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Oct 15, 2025

Uh oh!

rousseldenis commented Oct 15, 2025

Uh oh!

tarteo commented Oct 15, 2025

Uh oh!

tarteo commented Oct 15, 2025

Uh oh!

ivs-cetmix commented Oct 16, 2025

Uh oh!

chrisandrewmann commented Oct 24, 2025

Uh oh!

ivs-cetmix commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivs-cetmix commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

chrisandrewmann left a comment •

edited

Loading

chrisandrewmann commented Oct 8, 2025 •

edited

Loading

carlos-domatix left a comment •

edited

Loading

ivs-cetmix commented Oct 24, 2025 •

edited

Loading