[18.0][IMP] product_contract - add constraints #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbejaoui, |
anthonissen-a
force-pushed
the
18.0-product_contract_add_constraints-aan
branch
6 times, most recently
from
cfb98b3 to
fe0e004
Compare
yvaucher
requested changes
Oct 17, 2025
| return | ||
| if product.auto_renew_interval <= 0: | ||
| raise ValidationError( | ||
| f"Value of {product._fields['auto_renew_interval'].string}" |
There was a problem hiding this comment.
You want to make your error message translatable by wrapping them in env._ .
Be aware that vars included in the string will be evaluated inside the source string to translate.
https://www.odoo.com/documentation/18.0/developer/howtos/translations.html
What you want should be pretty close to this:
https://github.com/odoo/odoo/blob/18.0/addons/web_editor/models/ir_ui_view.py#L84-L88
| return | ||
| if product.termination_notice_interval < 0: | ||
| raise ValidationError( | ||
| f"Value of {product._fields['termination_notice_interval'].string}" |
| if not line.is_contract or not line.is_auto_renew: | ||
| return | ||
| if line.auto_renew_interval <= 0: | ||
| raise ValidationError( |
anthonissen-a
force-pushed
the
18.0-product_contract_add_constraints-aan
branch
2 times, most recently
from
08e1205 to
9065320
Compare
yvaucher
approved these changes
Oct 17, 2025
anthonissen-a
changed the title
anthonissen-a
force-pushed
the
18.0-product_contract_add_constraints-aan
branch
from
9065320 to
2bcf56c
Compare
|
Also added constraints to limit the range of:
|
anthonissen-a
force-pushed
the
18.0-product_contract_add_constraints-aan
branch
from
2bcf56c to
4e4b846
Compare
mamcode
approved these changes
Oct 18, 2025
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 constraints to limit the range of: