[15.0][ADD] hr_dms_field: New module #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
3 times, most recently
from
754efd3 to
2e00f89
Compare
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
3 times, most recently
from
74e9865 to
025413e
Compare
CarlosRoca13
force-pushed
the
15.0-add-hr_dms_field
branch
2 times, most recently
from
27a9815 to
0a907cd
Compare
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
4 times, most recently
from
52d33d1 to
88d5690
Compare
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
from
88d5690 to
ff6602f
Compare
2 tasks
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
3 times, most recently
from
6efec63 to
5ac7758
Compare
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
from
5ac7758 to
cd0f774
Compare
victoralmau
changed the title
|
Ping @pedrobaeza and @CarlosRoca13 |
pedrobaeza
reviewed
Feb 7, 2024
There was a problem hiding this comment.
In general it works OK, but it's ugly that each time you add a folder or a file into the embedded widget, the reload unfolds all the hierarchy, having to manually unfold again. I think the default should be unfolded by default, and if there's a possibility of keeping in the JS layer the folding state. But at least the first option should be implemented.
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
2 times, most recently
from
2974d9e to
bb00e80
Compare
|
It still keeps folded by default. |
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
from
bb00e80 to
adae7cc
Compare
Done. |
pedrobaeza
reviewed
Feb 8, 2024
- Create dms.field.template to set model, groups and directory structure. - Remove the wizard to create a directory from a record. - Directory structure is created when record is created (partner for example). - Change the information on the right side. - Have directory/file tree open when loading. TT46804 TT46804
victoralmau
force-pushed
the
15.0-add-hr_dms_field
branch
from
adae7cc to
6be59d1
Compare
Done. |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at bebb793. Thanks a lot for contributing to OCA. ❤️ |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done:
dms: Add ACLs todms.storagefor users with the basic permission.dms_field: Create dms.field.template to set model, groups and directory structure.dms_field: Remove the wizard to create a directory from a record.dms_field: Directory structure is created when record is created (partner for example).dms_field: Change the information on the right side.dms_field: Have directory/file tree open when loadingDirectory
File (preview when clicking on image/icon)
Please @pedrobaeza and @CarlosRoca13 can you review it?
@Tecnativa TT46804