Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] dms_auto_classification: New module #287

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[15.0][ADD] dms_auto_classification: New module #287

merged 1 commit into from
Feb 7, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Jan 23, 2024 •
edited
Loading

New module

ejemplo

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT46805

@victoralmau victoralmau force-pushed the 15.0-add-dms_auto_classification branch from 54c7c98 to d60e253 Compare January 23, 2024 09:13
@victoralmau victoralmau mentioned this pull request Jan 23, 2024
Merged
2 tasks
chienandalu
chienandalu approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

question: is it expected to discard those files not fulfilling the pattern?

@victoralmau
Copy link
Member Author

Tested 👍

question: is it expected to discard those files not fulfilling the pattern?

Yes, files that do not fulfilling the pattern are not added in details and therefore will not be created.

@victoralmau victoralmau force-pushed the 15.0-add-dms_auto_classification branch from d60e253 to 3e9fd9b Compare January 23, 2024 15:27
@victoralmau
Copy link
Member Author

Ping @pedrobaeza

@pedrobaeza pedrobaeza added this to the 15.0 milestone Feb 3, 2024
@victoralmau victoralmau force-pushed the 15.0-add-dms_auto_classification branch from 3e9fd9b to 71c9329 Compare February 5, 2024 08:44
@victoralmau
Copy link
Member Author

Changes done.

pedrobaeza
pedrobaeza approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-287-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit a1df13e into OCA:15.0 Feb 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 43d2ab3. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-dms_auto_classification branch February 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @OCA-git-bot @chienandalu @pedrobaeza