[15.0][FIX] dms: Improve the unlink method in base to avoid errors #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
approved these changes
Jan 26, 2024
|
I don't get the relation between the problem and this patch. |
In the uninstall process of dms, checks were made that prevented the removal of fields and models being deleted, also causing the dms_file and dms_directory tables to continue to exist.
victoralmau
force-pushed
the
15.0-fix-dms-unlink
branch
from
7a6c10d to
da34432
Compare
|
With this change when the module is uninstalled and Before this change and with the steps to reproduce the problem indicated, you can verify that the |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 4bff400. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #189
In the uninstall process of dms, checks were made that prevented the removal of fields and models being deleted, also causing the dms_file and dms_directory tables to continue to exist.
Steps to reproduce the error before:
@Tecnativa