Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] dms #292

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[14.0][FIX] dms #292

merged 1 commit into from
Feb 8, 2024

Conversation

adasatorres
Copy link
Contributor

Error when adding file using the file_ids field in directories view form.

The current_dir was an object of type NewID and there was a problem serializing it with the json.dumps method.

@pedrobaeza
Copy link
Member

Steps to reproduce the problem in a runboat?

@pedrobaeza pedrobaeza added this to the 14.0 milestone Feb 8, 2024
@adasatorres
Copy link
Contributor Author

@pedrobaeza go to some directory and try to add a file from file_ids field.
image
image

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the proper patch should be to replace line:

"id": current_dir.id,

with

"id": current_dir._origin.id,

@pedrobaeza
Copy link
Member

/ocabot merge patch

Please fw-port it to upper versions.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-292-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dfb0f55 into OCA:14.0 Feb 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 707a2bc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants