[15.0][FIX] dms: Fix smartbuttons from files and directories #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should change the first smart-button reference from |
chienandalu
reviewed
Feb 8, 2024
victoralmau
force-pushed
the
15.0-fix-dms-smartbuttons
branch
from
a62e06f to
00113b5
Compare
Sorry, I don't understand exactly where you mean (kanban view or form view). I think the buttons are currently displayed: Subdirectories and Files |
|
I mean in the commit message/PR message. |
Use case when clicking on smartbutton Files in a directory: - Only files in that directory or subdirectories are shown. - Only directory and child subdirectories are displayed in search panel. - Directory is auto-selected in search panel. Use case when clicking on smartbutton Subdirectories in a directory: - Only directories in that directory or subdirectories are displayed. - Directory is auto-selected in search panel.
victoralmau
force-pushed
the
15.0-fix-dms-smartbuttons
branch
from
00113b5 to
3107782
Compare
|
Changes done. |
pedrobaeza
approved these changes
Feb 12, 2024
chienandalu
approved these changes
Feb 12, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 57a31f9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case when clicking on smartbutton Files in a directory:
Use case when clicking on smartbutton Subdirectories in a directory:
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa