Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] dms: Improve tests #302

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Feb 16, 2024

Changes done:

  • Change setup() to setUpClass()
  • Add BaseCommon
  • Remove multi_users decorator (not used)
  • Remove _setup_test_data and _load from common (not used)
  • Change DirectoryMailTestCase (extends from StorageDatabaseBaseCase)
  • Add @mute_logger to skip unnecessary unlink logs

@Tecnativa

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 16, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi_users is not used anywhere?

@victoralmau
Copy link
Member Author

multi_users

No, @users('user-1', 'user-2') is used instead.

Changes done:
- Change setup() to setUpClass()
- Add BaseCommon
- Remove multi_users decorator (not used)
- Remove _setup_test_data and _load from common (not used)
- Change DirectoryMailTestCase (extends from StorageDatabaseBaseCase)
- Add @mute_logger to skip unnecessary unlink logs
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-302-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 56d7585 into OCA:16.0 Feb 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 081d6dc. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-dms-tests branch February 16, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants