[17.0][IMP+FIX] dms: Improve performance + Avoid non-existing record access error #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error Changes done: - Improve _dms_operations() method to do nothing if the model is not one of those used in dms.storage. - Avoid access error with .browse() if we access a non-existing record (for example, deleted by database). TT50231
UserWarning: dms.file: inconsistent 'store' for computed fields, accessing migration may recompute and update require_migration. Use distinct compute methods for stored and non-stored fields
victoralmau
force-pushed
the
17.0-fix-dms-TT50231
branch
from
1506000 to
515372f
Compare
pedrobaeza
approved these changes
Aug 20, 2024
chienandalu
approved these changes
Aug 20, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 769d7a2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 16.0: #359
Improve performance + Avoid non-existing record access error
Changes done:
_dms_operations()method to do nothing if the model is not one of those used indms.storage..browse()if we access a non-existing record (for example, deleted by database).Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT50231