Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] dms_attachment_link: Migration to 17.0 #373

Merged
merged 11 commits into from
Oct 11, 2024
Merged

[17.0][MIG] dms_attachment_link: Migration to 17.0 #373

merged 11 commits into from
Oct 11, 2024

Conversation

victoralmau
Copy link
Member

Migration to 17.0

Please @CarlosRoca13 and @pilarvargas-tecnativa can you review it?

@Tecnativa TT50055

victoralmau and others added 8 commits October 9, 2024 08:12
@victoralmau
[ADD] dms_attachment_link: New module
a0cc1c1 
TT41512

[UPD] Update dms_attachment_link.pot

[UPD] README.rst
@victoralmau
[IMP] dms_attachment_link: Add searchpanel to wizard to improve file …
15a6f13 
…selection.

TT41512

[UPD] Update dms_attachment_link.pot

dms_attachment_link 13.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: dms-13.0/dms-13.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-13-0/dms-13-0-dms_attachment_link/
@victoralmau
[MIG] dms_attachment_link: Migration to 15.0
181122c 
TT41774

[UPD] Update dms_attachment_link.pot

[UPD] README.rst
@Ivorra78 @victoralmau
Translated using Weblate (Spanish)
e45cc5b 
Currently translated at 100.0% (6 of 6 strings)

Translation: dms-15.0/dms-15.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_attachment_link/es/

[UPD] README.rst
@mymage @victoralmau
Added translation using Weblate (Italian)
491460d 
Translated using Weblate (Italian)

Currently translated at 100.0% (6 of 6 strings)

Translation: dms-15.0/dms-15.0-dms_attachment_link
Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_attachment_link/it/
@DemchukM @victoralmau
[MIG] dms_attachment_link: Migration to 16.0
395f435 
Co-authored-by: DemchukM
@victoralmau
[MIG] dms_attachment_link: Finish migration
50d2472 
[UPD] Update dms_attachment_link.pot
@victoralmau
[IMP] dms_attachment_link: pre-commit auto fixes
5bb5f5c
@pedrobaeza
Copy link
Member

/ocabot migration dms_attachment_link

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 9, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 9, 2024
Open
3 tasks
@victoralmau victoralmau force-pushed the 17.0-mig-dms_attachment_link branch from 883243c to 62a37d6 Compare October 9, 2024 08:33
@pilarvargas-tecnativa
Copy link

Following the instructions in the readme, the behaviour is not the same as in previous versions. For the ‘Add DMS files’ option to appear, a file must be uploaded. In previous versions, clicking on the chatter clip already showed this option.
dms

@victoralmau
Copy link
Member Author

Ok, I understand what you are saying, but in v17 that is the default behavior (https://github.com/odoo/odoo/blob/17.0/addons/mail/static/src/core/web/chatter.js). Should we change that behavior in this module? I think not, it should be done in another one.

Another module (document_url) does something similar https://github.com/OCA/knowledge/blob/17.0/document_url/static/src/js/url.esm.js#L38 (although I don't like the replace that is defined.)

What do you think @pedrobaeza

@pedrobaeza
Copy link
Member

We need to possibility of adding a DMS file although no current attachment, so yes, we should add that option in this module, similar to document_url.

@victoralmau
[MIG] dms_attachment_link: Migration to 17.0
49bed24 
TT50055
@victoralmau
[IMP] dms: Add the mk_file_kanban_view class to the custom kanban view
660c9e4 
Add the mk_file_kanban_view class to the custom kanban view so that it is
displayed correctly according to the styles set for that class (mk_file_kanban_view).

TT50055
@victoralmau victoralmau force-pushed the 17.0-mig-dms_attachment_link branch from 62a37d6 to 660c9e4 Compare October 11, 2024 07:19
pilarvargas-tecnativa
pilarvargas-tecnativa approved these changes Oct 11, 2024
View reviewed changes
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

pedrobaeza
pedrobaeza approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-373-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9d1a359 into OCA:17.0 Oct 11, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 141279a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-dms_attachment_link branch October 11, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu left review comments

@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@victoralmau @pedrobaeza @pilarvargas-tecnativa @OCA-git-bot @chienandalu @Ivorra78 @mymage @DemchukM