[16.0][ADD] sale_dms_field #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agent-z28
force-pushed
the
16.0-sale_dms_field-add-module
branch
from
13eb97c to
cb52ad0
Compare
victoralmau
suggested changes
Oct 18, 2024
There was a problem hiding this comment.
Code and functional review OK.
Some comments:
- According to the Guidelines change the PR title to
[16.0][ADD] sale_dms_field: New moduleand the commit message to:[ADD] sale_dms_field: New module. - If in sales we set sequences with dates and we use for example
S/%(year)swe will have an error similar toaccount_dms_field. I think that the most appropriate (in another PR) is to move https://github.com/OCA/dms/blob/16.0/account_dms_field/models/dms_field_template.py#L11 todms_field(it is only necessary to replace / to - and then it can be removed fromaccount_dms_fieldand it will work for this module (sale_dms_field) or any other.
agent-z28
force-pushed
the
16.0-sale_dms_field-add-module
branch
from
cb52ad0 to
255a821
Compare
|
@victoralmau i did the naming changes. |
|
The suggested change can be done in a new PR (it will be merged before this) or in this PR, but if it is done in this PR it should be the 1st commit (with a different message) and finally |
@victoralmau okay we will take care next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.