Skip to content

[16.0][ADD] dms_account_avatax_exemption#395

Closed
kobros-tech wants to merge 3 commits intoOCA:16.0from
kencove:16.0-add-dms_account_avatax_exemption
Closed

[16.0][ADD] dms_account_avatax_exemption#395
kobros-tech wants to merge 3 commits intoOCA:16.0from
kencove:16.0-add-dms_account_avatax_exemption

Conversation

@kobros-tech
Copy link
Copy Markdown
Contributor

This module connects between account avatax exemption dms modules.

@kobros-tech kobros-tech force-pushed the 16.0-add-dms_account_avatax_exemption branch from 91f5657 to b3e21ef Compare March 26, 2025 21:06
@kobros-tech
Copy link
Copy Markdown
Contributor Author

Screenshot from 2025-03-27 00-01-59
Screenshot from 2025-03-27 00-03-46
Screenshot from 2025-03-27 00-02-18

@kobros-tech kobros-tech force-pushed the 16.0-add-dms_account_avatax_exemption branch from b3e21ef to 49fa1c9 Compare March 26, 2025 23:29
@kobros-tech kobros-tech force-pushed the 16.0-add-dms_account_avatax_exemption branch from 49fa1c9 to a94fd04 Compare March 28, 2025 04:06
@kobros-tech
Copy link
Copy Markdown
Contributor Author

depends on:
OCA/account-fiscal-rule#512

@kobros-tech
Copy link
Copy Markdown
Contributor Author

Adding an exemption file will create an exemption line for the related partner:

Screenshot from 2025-03-28 09-05-18

Screenshot from 2025-03-28 09-05-44

@kobros-tech kobros-tech changed the title [DEV][16.0][ADD] dms_account_avatax_exemption [16.0][ADD] dms_account_avatax_exemption Mar 28, 2025
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 27, 2025
@kobros-tech kobros-tech force-pushed the 16.0-add-dms_account_avatax_exemption branch from e5140f1 to bc6906b Compare August 25, 2025 00:46
@kobros-tech
Copy link
Copy Markdown
Contributor Author

@pedrobaeza

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 26, 2025
@pedrobaeza
Copy link
Copy Markdown
Member

I think you can use https://github.com/OCA/dms/tree/16.0/dms_attachment_link as a general wildcard to select attachments from DMS.

@kobros-tech
Copy link
Copy Markdown
Contributor Author

kobros-tech commented Aug 27, 2025

@pedrobaeza

I reviewed the module functionality only not code that you told me about.

but this one will create one attachment with two dms.file records for for res.partner model and one for their exemption model.

In fact I am thinking about more further improvement by asking the partner on which type this file for like sign doc, exemption doc, offer, etc?

this will help us better to put the file in its best place.

it can be a JS wizard to select from combo box or check box,

but this case will need me to create a new module for the type of attachment we upload, what do you think?

@pedrobaeza
Copy link
Copy Markdown
Member

If this module continues as is, it should be hosted not here, but where account_avatax* modules lives (I think OCA/l10n-usa).

@kobros-tech
Copy link
Copy Markdown
Contributor Author

transeferred to OCA/l10n-usa#156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants