[16.0][FIX]dms: The method for uploading a file did not work when the folder was empty.#396
Merged
OCA-git-bot merged 1 commit intoOCA:16.0from Apr 10, 2025
Merged
Conversation
rrebollo
approved these changes
Mar 28, 2025
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review. LGTM! Amazing. I think this happens in v15 too.
Contributor
|
This PR has the |
pedrobaeza
reviewed
Apr 6, 2025
adasatorres
force-pushed
the
16.0-fix-dms
branch
from
103cfc6 to
ce69baf
Compare
pedrobaeza
approved these changes
Apr 10, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
/ocabot merge patch
Please fw-port it to 17
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 252ea92. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning, here is a possible solution for issue #390
The solution I propose is to use the
default_directory_idfrom the context of the current controller, as the directory is currently specified within a domain. If there is no domain, a file cannot be uploaded, but if there are no files, there is no domain either.