Skip to content

Conversation

rrebollo
Copy link

This module extends the functionality of course attendee views to show course's completed time.

After module installation, you will see course's completed time within attendee views.

attendees_tree_view

@BinhexTeam

@rrebollo
Copy link
Author

image

Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I explained myself properly. Thanks

@rrebollo rrebollo force-pushed the 16.0-add-website_slides_attendees_completed_time branch from 25b79fd to 622b1ec Compare April 29, 2025 10:24
…me tracking in attendee views

[IMP] website_slides_attendees_completed_time: compute attendee completed time through built-in recompute_completion feature

[IMP] website_slides_attendees_completed_time: enhance DESCRIPTION; implement tests for completed time
@rrebollo rrebollo force-pushed the 16.0-add-website_slides_attendees_completed_time branch from 622b1ec to c5bd082 Compare April 29, 2025 13:53
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review, LGTM

@rrebollo
Copy link
Author

✅ Update on the Approach Taken

Hello @Christian-RB and community,

After careful consideration, we’ve decided to align with the native _recompute_completion approach for tracking course progress. This decision has greatly simplified the logic and integration, and the overall flow of the feature now feels much smoother.

🔄 What Changed

The key update alongside this decision is that the field completed_time is no longer a computed field. Instead, it’s now a stored field that must be initialized with data when the addon is installed.

To ensure this, we’ve implemented a post_init_hook, which populates the completed_time values for all existing attendee records based on their current completed slides.

🧪 Tests Included

We’ve also added a suite of unit tests. These were designed following the pattern of the native tests for the completion field (which corresponds to the Progress column in the attendee view).

It’s important to highlight that although the completed_time and completion fields share similar purposes, their logic is not interchangeable:

  • completion (Progress) is slide-count based
  • completed_time is time-duration based and must remain an accurate, real-time reflection of the attendee’s completed course content

This means that updates to completed_time must respond to changes like:

  • Slides being archived or restored
  • Slides being marked as incomplete
  • Course structure being modified

We believe this dual-tracking (count-based + time-based) gives a more robust and insightful representation of learner engagement.


We’re now just awaiting the community’s feedback. Thanks for reviewing!

@Christian-RB
Copy link

@rrebollo Can you add the version [16.0] in the PR title? Thanks

@rrebollo rrebollo changed the title [ADD] website_slides_attendees_completed_time: show completed time in attendee views [16.0] [ADD] website_slides_attendees_completed_time: show completed time in attendee views Apr 29, 2025
Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

github-actions bot commented Oct 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants