Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] hr_holidays_auto_extend: Migration to 16.0 #136

Merged
merged 5 commits into from
Sep 5, 2024
Merged

[16.0] [MIG] hr_holidays_auto_extend: Migration to 16.0 #136

merged 5 commits into from
Sep 5, 2024

Conversation

luisDIXMIT
Copy link

@luisDIXMIT luisDIXMIT commented Aug 2, 2024 •
edited
Loading

Standard migration.
Extended test coverage.

@etobella

@luisDIXMIT luisDIXMIT force-pushed the 16.0-mig-hr_holidays_auto_extend branch from 045db41 to 3ba7756 Compare August 2, 2024 09:34
etobella
etobella approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-136-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 3, 2024
@OCA-git-bot
Merge PR #136 into 16.0
44154a3 
Signed-off-by etobella
@etobella
Copy link
Member

etobella commented Sep 3, 2024

/ocabot migration hr_holidays_auto_extend

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 3, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 3, 2024
Open
7 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-136-by-etobella-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Member

etobella commented Sep 3, 2024

@luisDIXMIT can you rebase and then we can check it?

@luisDIXMIT luisDIXMIT force-pushed the 16.0-mig-hr_holidays_auto_extend branch from 3ba7756 to d548adf Compare September 5, 2024 10:39
@luisDIXMIT
Copy link
Author

@etobella comments attended

@etobella
Copy link
Member

etobella commented Sep 5, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-136-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 54a991e into OCA:16.0 Sep 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5785e90. Thanks a lot for contributing to OCA. ❤️

@etobella etobella deleted the 16.0-mig-hr_holidays_auto_extend branch September 5, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrito gbrito gbrito approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@luisDIXMIT @OCA-git-bot @etobella @gbrito