[17.0][ADD] resource_calendar_get_days

[xaviedoanhduy]

The original development of this module has been done by Mint System.
It can be found in: https://github.com/Mint-System/Odoo-Apps-HR/tree/15.0/resource_calendar_get_days
This module has been ported to the OCA with their agreement, cc @janikvonrotz

- Supersedes: #129

[pedrobaeza]

Same questions as the other PR about Mint grant / CLA sign and the module name.

[leemannd]

Hello @janikvonrotz , your formal acceptation into the PR is welcome.
@xaviedoanhduy When opening such new PRs would it be possible to gently ask a review from the author of the module?

[pedrobaeza]

Another question is about the module name, as singular forms are advisable: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules

[janikvonrotz]

I was able to install the module and did a test similar to the tests.py:

Everything works as expected.

[janikvonrotz]

Same questions as the other PR about Mint grant / CLA sign and the module name.

I signed the CLA and support the migration.

[pedrobaeza]

Yes, great. The module name is the only remaining thing.

[leemannd]

Hello @pedrobaeza I must confess that on this case, the naming using the plural dosen't bother me.
The override done within the scope of this module is about the field and methods: days & _get_days_data

Maybe a better name could be resource_calendar_get_days_data_company , which in the other hand is super long.
Do you have a proposition on this topic?

[pedrobaeza]

Well, the description on the README is not very related: Show remaining leaves per employee in allocation overview., so I have no clue...

Requirements fulfilled

[janikvonrotz]

This is supposed to be "Calculate number of leave days relative to company working hours."

[xaviedoanhduy]

Hello @janikvonrotz, sorry for the omission, i have updated the description

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.