-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] hr_holidays_public: Migration to 18.0 #159
Open
xaviedoanhduy
wants to merge
96
commits into
OCA:18.0
Choose a base branch
from
xaviedoanhduy:18.0-imp-hr-holidays-public
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] hr_holidays_public: Migration to 18.0 #159
xaviedoanhduy
wants to merge
96
commits into
OCA:18.0
from
xaviedoanhduy:18.0-imp-hr-holidays-public
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add correct calculation of holidays in hr_public_holidays, instead of hr_holidays_compute_days. Remove dependancy of contracts. Add unlink at onchnage of public holiday lines. Update code. Fix flake. Update code, add calculation in hours, update views. Update flake. Update calendar creation with no attendances, otherwise default values were set. Remove config of show days/hours. Update flake. Update readme. Rename module. Updated holiday reports. Update klake and pylint. Update flaket. Update hr_holidays_views.xml Add readonly to show_full_days. Update code according with comments. Increase coverage. update flake8.
Hours part will be in module hr_holidays_hour.
Reduce to the minimum the footprint of this module, adding only public holidays as leaves in a transparent way by other modules.
This has been totally reworked for decoupling parts, not depending now on hr_holidays_public, and making transparent its use for compatibility with other modules.
Currently translated at 52.5% (21 of 40 strings) Translation: hr-11.0/hr-11.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_public/de/
Currently translated at 55.0% (22 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
Currently translated at 95.0% (38 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/fr/
Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/de/
Currently translated at 100.0% (40 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
…idays are defined for each year
Currently translated at 45.0% (18 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/pt_BR/
Since that PR, `_leave_intervals` is no longer called on days computations, so we intercept the batch method, but leaving the previous one for retro-compatibility.
- Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/
Currently translated at 100.0% (40 of 40 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/
…loyee Use case: - Go to Employees to an employee with a different address (country) than our own and with specific public holidays for that country. - Go to the Time-off smart-buttons - We will have to see there the public holidays according to the employee's address TT49839
…hod if the record does not exist yet)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/
Currently translated at 100.0% (41 of 41 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/
This change hooks into the core public holidays method that returns the employee's available holidays for a period of time and displays them in the Time Off dashboard calendar. Both types of public holidays are compatible and will show up in order. TT52276
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/
Currently translated at 100.0% (42 of 42 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
calendar_public_holiday
module.