[16.0][FIX] l10n_es_aeat_mod190: computo primeros hijos #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilioPascual
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Los tests están en rojo. |
EmilioPascual
force-pushed
the
16.0-l10n_es_aeat_mod_190-computo_primeros_hijos
branch
from
964c03b to
087c026
Compare
Ya están en verde. Salían en rojo pero no por este commit. |
pedrobaeza
reviewed
Feb 26, 2025
| @@ -240,6 +251,9 @@ class ResPartner(models.Model): | |||
| is_aeat_perception_subkey_visible = fields.Boolean( | |||
| compute="_compute_is_aeat_perception_subkey_visible" | |||
| ) | |||
| computo_primeros_hijos_visible = fields.Boolean( | |||
There was a problem hiding this comment.
Mejor seguir el mismo esquema de nombre, pero en este caso vamos ya a pasarlo a inglés:
Suggested change
| computo_primeros_hijos_visible = fields.Boolean( | |
| is_first_child_computation_visible = fields.Boolean( |
There was a problem hiding this comment.
Cambiado el nombre del campo al inglés
| @@ -1,5 +1,16 @@ | |||
| from odoo import api, fields, models | |||
|
|
|||
| COMPUTE_FIRST_KIDS_VISIBLE = { | |||
There was a problem hiding this comment.
Esto mejor que quede dentro del propio compute, ya que no tiene más uso que ése, y además, no es necesario hacer un diccionario con dos claves, solo tener dos variables con el listado de XML-IDs.
There was a problem hiding this comment.
Actualizado. Gracias por la aportación.
El computo de los 3 primeros hijos sólo debe ser visible para percepciones correspondientes a las claves A, B01, B03 y C @moduon MT-8874 Co-authored-by: Loida Vilaplana <[email protected]>
EmilioPascual
force-pushed
the
16.0-l10n_es_aeat_mod_190-computo_primeros_hijos
branch
from
087c026 to
b315aeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El computo de los 3 primeros hijos sólo debe ser visible para percepciones correspondientes a las claves A, B01, B03 y C siguiendo el último diseño de registro del modelo 190
Tal y como está ahora no se puede rellenar cuando se selecciona la clave A
Pero si aparece para otras claves que no debería.
@moduon MT-8874
@loida-vm @Shide @pedrobaeza @etobella @victoralmau podéis revisarlo, por favor. Gracias