Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] l10n_es_aeat_mod349 #4047

Open
wants to merge 115 commits into
base: 18.0
Choose a base branch
from

Conversation

pablo-cort-s73
Copy link

@pablo-cort-s73 pablo-cort-s73 commented Feb 25, 2025

Depends on:

Omar (pexego) and others added 30 commits February 25, 2025 16:17
…c module for aeat models, 347 module was portedto v6.0 and adds new module to print AEAT model 349.
…ueñas mejoras generales (vistas, traducciones, código) y corrección pequeño bug por un olvido en la adaptación de la v5 a la v6
* Only use the first four digits of fiscal year's code to determine fiscal year's number and also give a decent message to the user if it's not a number instead of simply crashing.
* Hacer opcional el campo Operation Key en las facturas, permitiendo que esté en blanco.
* Ser un poco menos rigurosos con que el año esté en el código del año fiscal. Atención: deberíamos añadir un campo con este valor en lugar de hacer este hack.
* FIX: Corregimos una serie de errores que había en las rectificaciones a la hora de obtener las declaraciones originales, si había alguna que cumplía los requisitos pero sin pertenecer a un modelo. Quizás se solucionara mejor con un on_delete='cascade'.
* RFR: Cambio de licencia de GPL3 a AGPL3 en el resto de módulos de localización española, con el consentimiento de todos los autores expresado vía lista de correo del equipo de localización [email protected]
* Only use the first four digits of fiscal year's code to determine fiscal year's number and also give a decent message to the user if it's not a number instead of simply crashing.
* Resolve a problem with python isinstance which considers 'False' is an integer and which makes OpenERP create operation_key field as integer instead of char.
* Convert a return None to return False, because the XML-RPC protocol doesn't support returning None.
…or: global name 'pooler' is not defined" al iniciar el calculo.
… sólo uno y arrelgar un bug en la generación del modelo cuando el partner tiene el campo title lleno.
…y H que son respectivamente Entregas intracomunitarias con exención de tasas y Entregas intracomunitarias con exención de tasas por un representante fiscal oficial fueron publicadas el 26/11/2011 en el boe. Se puede ver el artículo en: http://planartus.blogspot.es/1309888740/
…ron marcados como no instalables mientras no se compruebe que funcionan o migren, para poder usarlos o probarlos se debería poner el atributo installable de los ficheros __openerp__.py de cada módulo a True
…n os import de objetos de OpenERP, el namespace openerp, refactorizado a PEP-8 y adaptacion vistas a formato 7
…n_es_aeat.

* Traducciones.
* Vista del wizard BOE
* Vistas de facturas mejoradas
* Icono
* Asignar una clave a las facturas ya existentes.
…e o2m

[FIX] l10n_es_aeat_mod349: Añadida restricción que impide eliminar facturas que aparezcan en registros de detalle
* IMP: Fiscal position onchange in new API + speed imp + refactoring
* FIX: l10n_es_aeat_mod349: Remove check of names

  There's no need of a check about the name validity, because l10n_es_aeat
  already transform all the exported strings to valid ASCII characters
  (though unidecode), so I remove it entirely this check.

* FIX: Use first period year in export

  Relying in fiscal year code for getting the fiscal year is not safe,
  because you can use that code for defining your journal sequences (for
  example, with the module account_auto_fy_sequence).

  We can't use also the year of the fiscal year, because you can have
  split fiscal years (i. e. like the academic courses). What we uses then
  is the year of the first period of the declaration, as there's no
  legal possibility of having mixed periods from different years.
…er calcular el 349 en períodos distintos de los fiscales
Gelo-fl and others added 26 commits February 25, 2025 17:34
Currently translated at 100.0% (170 of 170 strings)

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/
Currently translated at 99.4% (169 of 170 strings)

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/es/
Currently translated at 100.0% (170 of 170 strings)

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/es/
Use case:
* Invoice January 2023: 1.000€
* Credit note February 2023: -200€
* credit note March 2023: -200€

Without the fix:
* 349 January total amount 1000€ (correct)
* 349 February total rectified amount 800€ (correct) and original amount 1000€ (correct)
* 349 March total rectified amount 800€ (incorrect) and original amount 1000€ (incorrect)

With the fix:
* 349 January total amount 1000€ (correct)
* 349 February total rectified amount 800€ (correct) and original amount 1000€ (correct)
* 349 March total rectified amount 600€ (correct) and original amount 800€ (correct)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/
Currently translated at 100.0% (170 of 170 strings)

Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_mod349/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat_mod349/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat_mod349/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-17.0/l10n-spain-17.0-l10n_es_aeat_mod349
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-17-0/l10n-spain-17-0-l10n_es_aeat_mod349/
This partially reverts commit 0e7847e,
amended later by 0e93183.
@HaraldPanten
Copy link
Contributor

Depends on: l10n_es_aeat_mod303

Hola Pablo, gracias por la aportación.

Estás seguro de que querías poner que depende del modelo 303? Puede ser que te hayas confundido?

Normalmente lo que se hace es referenciar a otro PR, en caso de que el módulo que estés migrando requiera de dependencias. Imagino que lo que querías decir es que depende de este otro PR, no? --> #4033

@pablo-cort-s73
Copy link
Author

pablo-cort-s73 commented Feb 25, 2025

Imagino que lo que querías decir es que depende de este otro PR, no? --> #4033

Tienes toda la razón, mis disculpas, estava viendo dependencias de otros módulos y lo he puesto por error.
Rectificado. Un saludo y gracias.

@pablo-cort-s73 pablo-cort-s73 force-pushed the 18.0-mig-l10n_es_aeat_mod349 branch from e2be68c to aebae10 Compare February 28, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.