-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][IMP] Improved l10n_us_form_1099 : 1099 classification by transaction #75
Open
Chanakya-SerpentCS
wants to merge
3
commits into
OCA:14.0
Choose a base branch
from
ursais:14.0_update_l10n_us_form_1099
base: 14.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,9 @@ To use this module, you need to: | |
#. If their type is 1099-MISC, you can select their box | ||
#. Go to Invoicing > Bills > Vendors | ||
#. Create vendor bills and payments for those 1099 vendors | ||
#. Modify "Is a 1099" box on Bill Lines based on your need | ||
#. Go to Invoicing > Reporting > 1099 Report | ||
#. If Bill is fully paid then payments will be included in Report | ||
|
||
Bug Tracker | ||
=========== | ||
|
@@ -93,6 +95,7 @@ Contributors | |
* Bhavesh Odedra <[email protected]> | ||
* Brian McMaster <[email protected]> | ||
* Jevin Dement <[email protected]> | ||
* Chankya Soni <[email protected]> | ||
|
||
Other credits | ||
~~~~~~~~~~~~~ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# Copyright (C) 2019 Open Source Integrators | ||
# Copyright (C) 2021 Open Source Integrators | ||
# Copyright (C) 2019 Brian McMaster | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
from . import type_1099, box_1099_misc, res_partner | ||
from . import type_1099, box_1099_misc, res_partner, account_move |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
# Copyright (C) 2021 Open Source Integrators | ||
# Copyright (C) 2019 Brian McMaster | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
from odoo import api, fields, models | ||
|
||
|
||
class AccountMove(models.Model): | ||
_inherit = "account.move" | ||
|
||
@api.onchange("partner_id") | ||
def _onchange_partner_id(self): | ||
"""If lines are already added and user change the partner then | ||
set 1099 information from the new partner""" | ||
result = super(AccountMove, self)._onchange_partner_id() | ||
self.invoice_line_ids.is_1099 = self.partner_id.is_1099 | ||
self.invoice_line_ids.type_1099_id = self.partner_id.type_1099_id.id | ||
self.invoice_line_ids.box_1099_misc_id = self.partner_id.box_1099_misc_id.id | ||
return result | ||
|
||
|
||
class AccountMoveLine(models.Model): | ||
_inherit = "account.move.line" | ||
|
||
is_1099 = fields.Boolean("Is a 1099?", compute="_compute_is_1099", store=True) | ||
type_1099_id = fields.Many2one("type.1099", string="1099 Type") | ||
box_1099_misc_id = fields.Many2one("box.1099.misc", string="1099-MISC Box") | ||
legal_id_number = fields.Char( | ||
related="partner_id.legal_id_number", string="Legal ID" | ||
) | ||
|
||
@api.depends("product_id") | ||
def _compute_is_1099(self): | ||
for record in self: | ||
record.is_1099 = ( | ||
record.move_id.partner_id.is_1099 | ||
and record.product_id.type == "service" | ||
) | ||
|
||
@api.model | ||
def default_get(self, default_fields): | ||
# OVERRIDE | ||
# Update is_1099, type_1099_id and box_1099_misc_id from default partner | ||
values = super(AccountMoveLine, self).default_get(default_fields) | ||
if values.get("partner_id"): | ||
partner = self.env["res.partner"].browse(values.get("partner_id")) | ||
values.update( | ||
{ | ||
"is_1099": partner.is_1099, | ||
"type_1099_id": partner.type_1099_id.id, | ||
"box_1099_misc_id": partner.box_1099_misc_id.id, | ||
} | ||
) | ||
return values | ||
|
||
@api.onchange("is_1099", "type_1099_id") | ||
def onchange_is_1099(self): | ||
if not self.is_1099: | ||
self.type_1099_id = False | ||
self.box_1099_misc_id = False | ||
type_1099_id = self.env.ref("l10n_us_form_1099.1099_type_misc") | ||
if self.type_1099_id != type_1099_id: | ||
self.box_1099_misc_id = False |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Copyright (C) 2017 Open Source Integrators | ||
# Copyright (C) 2021 Open Source Integrators | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
# Copyright (C) 2019 Brian McMaster | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
<odoo> | ||
<!-- Copyright (C) 2021 Open Source Integrators Copyright (C) 2019 Brian | ||
McMaster License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). --> | ||
|
||
<record id="account_move_view_form_l10n_us_1099" model="ir.ui.view"> | ||
<field name="name">account_move_line_view_form</field> | ||
<field name="model">account.move</field> | ||
<field name="inherit_id" ref="account.view_move_form" /> | ||
<field name="arch" type="xml"> | ||
<xpath | ||
expr="//field[@name='invoice_line_ids']//field[@name='account_id']" | ||
position="after" | ||
> | ||
<field | ||
name="is_1099" | ||
attrs="{'column_invisible' : [('parent.move_type', '!=', 'in_invoice')]}" | ||
/> | ||
<field | ||
name="type_1099_id" | ||
options="{'no_create': 1, 'no_open':1}" | ||
attrs="{'readonly': [('is_1099', '=', False)], 'column_invisible' : [('parent.move_type', '!=', 'in_invoice')]}" | ||
/> | ||
<field | ||
name="box_1099_misc_id" | ||
options="{'no_create': 1, 'no_open':1}" | ||
attrs="{'readonly': ['|',('is_1099', '=', False),('type_1099_id', '!=', %(l10n_us_form_1099.1099_type_misc)d)], | ||
'column_invisible' : [('parent.move_type', '!=', 'in_invoice')]}" | ||
/> | ||
<field | ||
name="legal_id_number" | ||
attrs="{'column_invisible' : [('parent.move_type', '!=', 'in_invoice')]}" | ||
/> | ||
</xpath> | ||
|
||
<xpath | ||
expr="//field[@name='line_ids']//field[@name='account_id']" | ||
position="after" | ||
> | ||
<field name="is_1099" invisible="1" /> | ||
<field | ||
name="type_1099_id" | ||
options="{'no_create': 1, 'no_open':1}" | ||
attrs="{'readonly': [('is_1099', '=', False)]}" | ||
invisible="1" | ||
/> | ||
<field | ||
name="box_1099_misc_id" | ||
options="{'no_create': 1, 'no_open':1}" | ||
invisible="1" | ||
attrs="{'readonly': ['|', ('is_1099', '=', False),('type_1099_id', '!=', %(l10n_us_form_1099.1099_type_misc)d)]}" | ||
/> | ||
<field name="legal_id_number" invisible="1" /> | ||
</xpath> | ||
|
||
</field> | ||
</record> | ||
|
||
</odoo> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don'a change the work year please