[15.0] Add option to show account details before KPI on instance #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sa3m wants to merge 4 commits into OCA:15.0 from sa3m:inverse-detail

sa3m commented Oct 5, 2023 •

edited

Loading

Hello,

I added an option to show the detail of the accounts before the KPI (requested by my customer).
I thought it might interest the community.
I know it lacks unit tests but it can be added if the feature is found useful.

Cheers,

Samuel

Contributor

OCA-git-bot commented Oct 5, 2023

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

sa3m changed the title ~~Add inverse detail option to instance~~ [15.0] Add inverse detail option to instance


          Add inverse detail option to instance

c388fe2

sa3m force-pushed the inverse-detail branch from 3abaf9c to c388fe2 Compare

October 5, 2023 01:01

sbidoul reviewed

View reviewed changes

Member

sbidoul left a comment

Hi, thanks for the contrib.
This sounds useful to me and the implementation looks ok.
I made a few minor comments.
And a test, yes :)

mis_builder/models/kpimatrix.py Outdated Show resolved Hide resolved

mis_builder/models/mis_report_instance.py Outdated Show resolved Hide resolved

mis_builder/views/mis_report_instance.xml Outdated Show resolved Hide resolved

sa3m force-pushed the inverse-detail branch from 38c7949 to a2a5fbc Compare

October 5, 2023 22:48


          [FIX] applied sbidoul comments

a13f928

sa3m force-pushed the inverse-detail branch from a2a5fbc to a13f928 Compare

October 5, 2023 22:50

sa3m changed the title ~~[15.0] Add inverse detail option to instance~~ [15.0] Add option to show account details before KPI on instance

sa3m added 2 commits

October 6, 2023 10:40


          [IMP] Add test

899f8c9


          [FIX] Tests in data sources instead of instance

82561ad

Author

sa3m commented Oct 10, 2023

I added 2 tests (without and with the setting). I had to add it in test_data_sources to have proper data to test it on.
Tell me if it's okay with you.

github-actions bot commented Feb 11, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions bot added the stale label

sbidoul removed the stale label

github-actions bot commented Jun 16, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions bot added the stale label

github-actions bot closed this

sbidoul reopened this

Contributor

OCA-git-bot commented Jul 23, 2024

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

github-actions bot removed the stale label

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions bot added the stale label

Author

sa3m commented Dec 3, 2024

@sbidoul Do you have any comment on this ? Thanks

github-actions bot removed the stale label

sbidoul added the 15.0 label

github-actions bot commented Apr 13, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions bot added the stale label

Author

sa3m commented May 15, 2025

Anything new on this ?

github-actions bot removed the stale label

github-actions bot commented Sep 21, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions bot added the stale label

sbidoul removed the stale label

sbidoul added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

15.0 enhancement