Skip to content

[FIX] account_invoice_inter_company : creating a credit note should g…#738

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
Groupe-Voltaire-SAS:16.0-fix_invoice_inter_company_full_refund
Feb 20, 2025
Merged

[FIX] account_invoice_inter_company : creating a credit note should g…#738
OCA-git-bot merged 1 commit intoOCA:16.0from
Groupe-Voltaire-SAS:16.0-fix_invoice_inter_company_full_refund

Conversation

@metaminux
Copy link
Copy Markdown
Contributor

@metaminux metaminux commented Dec 11, 2024 •
edited
Loading

…enerate a supplier refund in the other company

Fix #736

@metaminux metaminux force-pushed the 16.0-fix_invoice_inter_company_full_refund branch 3 times, most recently from e482b0a to 7c04445 Compare December 11, 2024 16:47
rvalyi
rvalyi approved these changes Dec 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Just a note, in the future try to limit git messages to 50 chars, see https://github.com/OCA/odoo-community.org/blob/master/website%2FContribution%2FCONTRIBUTING.rst#commit-message

@metaminux
Copy link
Copy Markdown
Contributor Author

metaminux commented Dec 11, 2024

OK. Just a note, in the future try to limit git messages to 50 chars, see https://github.com/OCA/odoo-community.org/blob/master/website%2FContribution%2FCONTRIBUTING.rst#commit-message

Noted ! 👍🏼

@metaminux metaminux force-pushed the 16.0-fix_invoice_inter_company_full_refund branch from 7c04445 to 0515073 Compare December 13, 2024 08:53
@metaminux
Copy link
Copy Markdown
Contributor Author

metaminux commented Dec 13, 2024

@Kev-Roche @emiliesoutiras Can you review this one ?

@pedrobaeza @sebastienbeau default branch for OCA/multi-company is still 14.0, so this PR is not linked to its related isssue #736...

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 17, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@metaminux metaminux force-pushed the 16.0-fix_invoice_inter_company_full_refund branch from 0515073 to 41a8fcc Compare December 18, 2024 15:16
@HviorForgeFlow
Copy link
Copy Markdown
Member

HviorForgeFlow commented Jan 7, 2025

@rvalyi let's merge it

@metaminux
Copy link
Copy Markdown
Contributor Author

metaminux commented Jan 7, 2025 •
edited
Loading

Before merging... it seems that we need to better check if an inter company invoice doesn't already exist.

I'd like to add another test when one of the invoice/refund is canceled and posted again...

@metaminux @emiliesoutiras
[FIX] account_invoice_inter_company : creating a credit note should g…
7c29877 
…enerate a supplier refund in the other company

Fixes OCA#736
@emiliesoutiras emiliesoutiras force-pushed the 16.0-fix_invoice_inter_company_full_refund branch from 41a8fcc to 7c29877 Compare February 4, 2025 11:36
@emiliesoutiras
Copy link
Copy Markdown

emiliesoutiras commented Feb 4, 2025

rebase changes

@legalsylvain
Copy link
Copy Markdown
Contributor

legalsylvain commented Feb 20, 2025

no review.

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 20, 2025

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-738-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 20, 2025
@OCA-git-bot
Merge PR #738 into 16.0
de1e006 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 20, 2025

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-738-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 20, 2025
@OCA-git-bot
Merge PR #738 into 16.0
6398793 
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 20, 2025

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-738-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 759c58b into OCA:16.0 Feb 20, 2025
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Feb 20, 2025

Congratulations, your PR was merged at 36a1b51. Thanks a lot for contributing to OCA. ❤️

@metaminux metaminux deleted the 16.0-fix_invoice_inter_company_full_refund branch February 21, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes

+2 more reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@emiliesoutiras emiliesoutiras emiliesoutiras approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@metaminux @OCA-git-bot @HviorForgeFlow @emiliesoutiras @legalsylvain @rvalyi