[16.0][FIX] base_multi_company: support `in False` search operators by yajo · Pull Request #760 · OCA/multi-company

yajo · 2025-01-29T11:28:01Z

Before this commit, when doing a read with a domain such as the one used by upstream base.res_partner_rule, the read failed to find records without company.

This is now fixed in the base module, adding tested support for such operators. The only relevant part of the hooks that were provided to workaround the issue is extracted to a new post_init_hook. All other hooks are marked as deprecated.

Instructions for functional tests: This refactor is internal and should not be noticed functionally. The modules product_multi_company and partner_multi_company should work just as always. If so, then this is good.

@moduon MT-8863 MT-8873

OCA-git-bot · 2025-01-29T11:28:06Z

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

Now that `base_multi_company` supports `('company_id', 'in', some_ids + [False])` domains since OCA#760, it's time to remove the (un)install hooks that changed those rules. The fix is important when migrating a database from previous versions where these hooks didn't exist. In those cases, users wouldn't be able to browse some partners, getting a weird `AccessError`. FWIW, [upstream rules changed for performance][2], so the uninstall hook had to be changed nevertheless. [2]: odoo/odoo@a04df5c#diff-1f2cafa0e26df218210181c72e599c279fd093c4215d1dc1da5ef8875195e6c2L23-R23 @moduon MT-8863

… company assignments Remove lots of code thanks to OCA#760. Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation. @moduon MT-8863

edlopen

Code review here. LGTM!

Before this commit, when doing a read with a domain such as [the one used by upstream `base.res_partner_rule`][1], the read failed to find records without company. This is now fixed in the base module, adding tested support for such operators. The only relevant part of the hooks that were provided to workaround the issue is extracted to a new `post_init_hook`. All other hooks are marked as deprecated. [1]: https://github.com/odoo/odoo/blob/db072461cddced2a8f65a64fb6d2ddf0dd79b38e/odoo/addons/base/security/base_security.xml#L23 @moduon MT-8863 MT-8873

… company assignments Remove lots of code thanks to OCA#760. Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation. @moduon MT-8873

loida-vm

Functional review done.

I have verified that both in the Products module

and in Contacts

it is allowed to select the companies we want for sharing.

LGTM!
Thanks @yajo

rafaelbn · 2025-01-29T14:05:46Z

This module is already migrated to 17 and the is a PR for 18.

@victoralmau @pedrobaeza @chienandalu could you review please? We can fordward port to all versions.

Thank you! 😄

Note Odoo 18 migration #708

pedrobaeza

/ocabot merge major

OCA-git-bot · 2025-02-11T07:26:24Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-760-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot · 2025-02-11T07:31:12Z

Congratulations, your PR was merged at 93c447e. Thanks a lot for contributing to OCA. ❤️

Now that `base_multi_company` supports `('company_id', 'in', some_ids + [False])` domains since OCA#760, it's time to remove the (un)install hooks that changed those rules. The fix is important when migrating a database from previous versions where these hooks didn't exist. In those cases, users wouldn't be able to browse some partners, getting a weird `AccessError`. FWIW, [upstream rules changed for performance][2], so the uninstall hook had to be changed nevertheless. [2]: odoo/odoo@a04df5c#diff-1f2cafa0e26df218210181c72e599c279fd093c4215d1dc1da5ef8875195e6c2L23-R23 @moduon MT-8863

… company assignments Remove lots of code thanks to OCA#760. Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation. @moduon MT-8873

yajo · 2025-02-12T09:25:42Z

Thanks everyone!

Now that this is merged, please review #761 and #762, which are the refactors for modules that implement this same behavior on partners and products respectively.

Just like here, the refactor is internal, and if modules just work as always, then it's OK.

… company assignments Remove lots of code thanks to OCA#760. Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation. @moduon MT-8873

victoralmau · 2025-03-12T15:42:14Z

Can you add these changes also to v17 so I can bring them also to v18 in #790?

yajo · 2025-03-18T12:07:57Z

I'd love to, but right now I don't think I'll have the time to do so. Maybe maybe you can just fwport this to v18 directly?

victoralmau · 2025-03-18T13:29:56Z

I'd love to, but right now I don't think I'll have the time to do so. Maybe maybe you can just fwport this to v18 directly?

Ok, thanks for clarifying, I don't have time either.
Whenever an improvement/fix is added, I think it is appropriate (should be mandatory in my opinion) to add those changes to higher versions, or else, we will find ourselves with bugs already resolved simply because no time has been spent to do so. I always do it, and personally I find it somewhat “selfish” to say that one does not have time, maybe not having time now ok, but doing it soon ok, not avoiding that someone will end up doing it (because at some point someone will stop doing it).

… company assignments Remove lots of code thanks to OCA#760. Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation. @moduon MT-8873

yajo mentioned this pull request Jan 29, 2025

[16.0][FIX] partner_multi_company: remove unnecessary rule rewrite hooks #761

Merged

1 task

yajo marked this pull request as draft January 29, 2025 11:45

yajo force-pushed the 16.0-base_multi_company-fix_in_false branch 3 times, most recently from 2805d27 to d34f488 Compare January 29, 2025 11:56

yajo marked this pull request as ready for review January 29, 2025 12:02

yajo mentioned this pull request Jan 29, 2025

[16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments #762

Merged

1 task

yajo force-pushed the 16.0-base_multi_company-fix_in_false branch from d34f488 to 6875f5a Compare January 29, 2025 12:10

EmilioPascual approved these changes Jan 29, 2025

View reviewed changes

edlopen approved these changes Jan 29, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 29, 2025

yajo force-pushed the 16.0-base_multi_company-fix_in_false branch from 6875f5a to aee7d28 Compare January 29, 2025 12:47

loida-vm approved these changes Jan 29, 2025

View reviewed changes

Shide approved these changes Jan 29, 2025

View reviewed changes

yajo mentioned this pull request Jan 30, 2025

[18.0][MIG] base_multi_company: Migration to 18.0 #708

Closed

victoralmau approved these changes Feb 10, 2025

View reviewed changes

pedrobaeza added this to the 16.0 milestone Feb 11, 2025

pedrobaeza changed the title ~~[FIX] base_multi_company: support in False search operators~~ [16.0][FIX] base_multi_company: support in False search operators Feb 11, 2025

pedrobaeza approved these changes Feb 11, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 11, 2025

OCA-git-bot merged commit f6aa60a into OCA:16.0 Feb 11, 2025

OCA-git-bot removed the bot is merging ⏳ label Feb 11, 2025

OCA-git-bot added the merged 🎉 label Feb 11, 2025

yajo deleted the 16.0-base_multi_company-fix_in_false branch February 12, 2025 09:21

LoisRForgeFlow mentioned this pull request May 7, 2025

[18.0] [MIG] base_multi_company: Migration to 18.0 #790

Closed

etobella mentioned this pull request Jul 17, 2025

[17.0][IMP+FIX+I18N] l10n_es_vat_prorate: Feedback from v16 backport OCA/l10n-spain#4288

Merged

ArnauCForgeFlow mentioned this pull request Aug 6, 2025

[17.0][FWP][FIX] base_multi_company: support in False search operators #865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[16.0][FIX] base_multi_company: support `in False` search operators#760

[16.0][FIX] base_multi_company: support `in False` search operators#760
OCA-git-bot merged 1 commit intoOCA:16.0from
moduon:16.0-base_multi_company-fix_in_false

yajo commented Jan 29, 2025 •

edited

Loading

Uh oh!

OCA-git-bot commented Jan 29, 2025

Uh oh!

edlopen left a comment

Uh oh!

loida-vm left a comment •

edited

Loading

Uh oh!

rafaelbn commented Jan 29, 2025

Uh oh!

pedrobaeza left a comment

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

yajo commented Feb 12, 2025

Uh oh!

victoralmau commented Mar 12, 2025

Uh oh!

yajo commented Mar 18, 2025

Uh oh!

victoralmau commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

yajo commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented Jan 29, 2025

Uh oh!

edlopen left a comment

Choose a reason for hiding this comment

Uh oh!

loida-vm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rafaelbn commented Jan 29, 2025

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

OCA-git-bot commented Feb 11, 2025

Uh oh!

yajo commented Feb 12, 2025

Uh oh!

victoralmau commented Mar 12, 2025

Uh oh!

yajo commented Mar 18, 2025

Uh oh!

victoralmau commented Mar 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

yajo commented Jan 29, 2025 •

edited

Loading

loida-vm left a comment •

edited

Loading