Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ENH] hr_operating_unit: add OU to department #562

Open
wants to merge 2 commits into
base: 15.0
Choose a base branch
from
Open

[15.0][ENH] hr_operating_unit: add OU to department #562

wants to merge 2 commits into from

Conversation

ps-tubtim
Copy link
Member

Adds an operating unit to the department

Selection_182

@ps-tubtim ps-tubtim changed the title [ENH] hr_operating_unit: add OU to department [15.0][ENH] hr_operating_unit: add OU to department Feb 14, 2023
Saran440
Saran440 reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, delete filter with domain users. it will see 1 ou only if you add domain user.

hr_operating_unit/views/hr_department_views.xml Outdated
name="operating_unit_id"
options="{'no_create': True}"
domain="[('company_id','=', company_id),
('user_ids', 'in', uid)]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('user_ids', 'in', uid)]"
]"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saran440 I already updated it.

hr_operating_unit/views/hr_department_views.xml Outdated
<field name="parent_id" position="after">
<field
name="operating_unit_id"
domain="[('user_ids', 'in', uid)]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
domain="[('user_ids', 'in', uid)]"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saran440 I already updated it.

Saran440
Saran440 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Saran440
Copy link
Member

Saran440 commented Mar 8, 2023

This PR fixed domain users in hr.employee

Selection_012

TheerayutEncoder
TheerayutEncoder approved these changes Jun 7, 2023
View reviewed changes
Copy link

@TheerayutEncoder TheerayutEncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@AaronHForgeFlow
Copy link
Contributor

I am not a user of this module, but this change seems legit. I would recommend to do a migration script to prefill the information in the department.

@Saran440
Copy link
Member

Saran440 commented Jun 9, 2023

@AaronHForgeFlow I think this enhance shouldn't migration script because all department will default 1 OU

Example:

Case 1 (No script)
Deparmtent A - No OU
Deparmtent B - No OU
Deparmtent C - No OU
Deparmtent D - No OU

Case 2 (there is script)
Deparmtent A - OU 1
Deparmtent B - OU 1
Deparmtent C - OU 1
Deparmtent D - OU 1

Case1 all user can see department
Case2 user OU1 can see all department, it must change some department to correct OU
I think case1 is makesense more than

What do you think?

@Saran440 Saran440 force-pushed the 15.0-enh-hr_operating_unit branch from c63367f to ce99855 Compare June 9, 2023 09:03
@AaronHForgeFlow
Copy link
Contributor

@Saran440 , I think that makes sense.

Would it make sense to put a restriction so the operating unit of the employee cannot be different from the operating unit of the department?

In any case I am not using this module and I prefer actual users to discuss this.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow
AaronHForgeFlow reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ps-tubtim as the change is quite major and I am not using this module I would rather like to have more approvals from actual users. Code LG

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@AaronHForgeFlow AaronHForgeFlow removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 21, 2024
@Saran440 Saran440 force-pushed the 15.0-enh-hr_operating_unit branch from 183732c to 960774b Compare July 8, 2024 04:20
@Saran440 Saran440 force-pushed the 15.0-enh-hr_operating_unit branch from 960774b to a2cdfc1 Compare July 8, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow left review comments

@Saran440 Saran440 Saran440 approved these changes

@TheerayutEncoder TheerayutEncoder TheerayutEncoder approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ps-tubtim @Saran440 @AaronHForgeFlow @OCA-git-bot @TheerayutEncoder @Pani-k-folk