Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] sale_operating_unit #600

Open
wants to merge 33 commits into
base: 16.0
Choose a base branch
from

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Jun 22, 2023

Migration hr_operating_unit from 15.0 to 16.0
Depends #596 and #592

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso mentioned this pull request Jun 22, 2023
10 tasks
@Borruso Borruso force-pushed the 16.0-mig-sale_operating_unit branch from 5e22473 to 3a7a766 Compare July 17, 2023 15:18
@AaronHForgeFlow
Copy link
Contributor

AaronHForgeFlow commented Jul 20, 2023

Edit: wrong comment

@api.onchange("operating_unit_id")
def onchange_operating_unit_id(self):
if self.team_id and self.team_id.operating_unit_id != self.operating_unit_id:
self.team_id = False

This comment was marked as resolved.

@Borruso Borruso force-pushed the 16.0-mig-sale_operating_unit branch from 3a7a766 to 284326b Compare August 23, 2023 15:34
@Borruso Borruso requested a review from alan196 August 23, 2023 15:34
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical & Funcional review 👍

@alan196
Copy link
Contributor

alan196 commented Sep 4, 2023

I detected an issue and make PR Borruso#1 to fix it

@max3903 max3903 added this to the 16.0 milestone Sep 7, 2023
@max3903
Copy link
Member

max3903 commented Sep 7, 2023

/ocabot migration sale_operating_unit

Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@AaronHForgeFlow AaronHForgeFlow added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 8, 2024
@hbrunn hbrunn mentioned this pull request Jul 25, 2024
@AaronHForgeFlow
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM. In v15 the issue commented exists as well so maybe we can merge this and propose a new PR for the fix.

@AaronHForgeFlow
Copy link
Contributor

Pending to include this small improvement: #706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved migration needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.