Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP]mis_builder_operating_unit Filter account entries not having operating unit #653

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[15.0][IMP]mis_builder_operating_unit Filter account entries not having operating unit #653

merged 1 commit into from
Aug 26, 2024

Conversation

AaronHForgeFlow
Copy link
Contributor

FW #651

robyf70
robyf70 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow
Copy link
Contributor Author

There is some issue in the account_operating_unit module, tests are failing

@robyf70
Copy link
Contributor

robyf70 commented Mar 6, 2024

There is some issue in the account_operating_unit module, tests are failing

The issue is raised as

raise ValidationError(_("The selected payment method is not available for this payment, please select the payment method again."))

see here https://github.com/OCA/operating-unit/actions/runs/8170230486/job/22335955970?pr=653#step:8:733

@AaronHForgeFlow
Copy link
Contributor Author

I will check when having some time.

@robyf70
Copy link
Contributor

robyf70 commented Mar 6, 2024

I will check when having some time.

I've committed the fix see #654

@AaronHForgeFlow
Copy link
Contributor Author

Thank you @robyf70 this is green now :)

@robyf70
Copy link
Contributor

robyf70 commented Apr 9, 2024

Thank you @robyf70 this is green now :)

Any chance to get it merged?

@robyf70
Copy link
Contributor

robyf70 commented Apr 15, 2024

@AaronHForgeFlow Can apply the changes as per #651 so we have all uniform?

@AaronHForgeFlow
Copy link
Contributor Author

@robyf70 sure! in any case this should not me merged until the other is merged

@AaronHForgeFlow AaronHForgeFlow changed the title [15.0][IMP]mis_builder_operating_unit Filter account entries not having operating unit (WIP)[15.0][IMP]mis_builder_operating_unit Filter account entries not having operating unit Apr 16, 2024
@AaronHForgeFlow AaronHForgeFlow changed the title (WIP)[15.0][IMP]mis_builder_operating_unit Filter account entries not having operating unit [15.0][IMP]mis_builder_operating_unit Filter account entries not having operating unit May 3, 2024
@AaronHForgeFlow
Copy link
Contributor Author

keeping branches even
/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-653-by-AaronHForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ba409d2 into OCA:15.0 Aug 26, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1af1120. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-fw-651 branch August 26, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyf70 robyf70 robyf70 approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronHForgeFlow @robyf70 @OCA-git-bot @MiquelRForgeFlow