Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] sale_operating_unit: allowed to hide operating_unit_id in list views #657

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

alexeirivera87
Copy link

added optional="hide"

@alexeirivera87
Copy link
Author

Hello @AaronHForgeFlow

Could you please check this small adjustment?

regards

@AaronHForgeFlow
Copy link
Contributor

put optional="show" instead

That way there is no changes for current users.

@alexeirivera87
Copy link
Author

@AaronHForgeFlow

It's done.

regards

@AaronHForgeFlow
Copy link
Contributor

@alexeirivera87 Thanks. You can add yourself in the the contributors.rst file but please do not change Readme.rst file. The oca bot will do that.

Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeirivera87
Copy link
Author

alexeirivera87 commented May 14, 2024

@alexeirivera87 Thanks. You can add yourself in the the contributors.rst file but please do not change Readme.rst file. The oca bot will do that.

@AaronHForgeFlow
Ah, copied. I did not know that. Should I revert the change in the readme file? In order to get this PR approved/merged?

@AaronHForgeFlow
Copy link
Contributor

@alexeirivera87 no, it is not that important

@AaronHForgeFlow
Copy link
Contributor

I don't mind to merge it just waiting for some other users to approve

@alexeirivera87
Copy link
Author

Hello @MiquelRForgeFlow

I saw you approved other PR in this repository. Could you please check this one? Thanks in advance.

@alexeirivera87
Copy link
Author

Hello @AaronHForgeFlow

Can this PR be merged?

regards

@AaronHForgeFlow
Copy link
Contributor

ok, let's do it, it is a minor change. The other needed approval is implicit in the other comment.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-657-by-AaronHForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d1cb963 into OCA:14.0 Sep 12, 2024
4 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 021d5bb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants