Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_stock_operating_unit: Migration to 17.0 #676

Merged
merged 27 commits into from
Aug 7, 2024
Merged

[MIG] sale_stock_operating_unit: Migration to 17.0 #676

merged 27 commits into from
Aug 7, 2024

Conversation

jdidderen-nsi
Copy link
Contributor

@jdidderen-nsi jdidderen-nsi commented May 29, 2024 •
edited by yvaucher
Loading

@AaronHForgeFlow
Copy link
Contributor

/ocabot migration sale_stock_operating_unit

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 29, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 29, 2024
Open
16 tasks
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-sale_stock_operating_unit branch from da4c0a7 to 32858c8 Compare June 11, 2024 09:17
nguyenminhchien
nguyenminhchien approved these changes Jun 18, 2024
View reviewed changes
Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good overall, just left 2 comments for considering.

sale_stock_operating_unit/models/stock_move.py
@@ -12,7 +12,7 @@ def _get_new_picking_values(self):
"""
Override to add Operating Units to Picking.
"""
values = super(StockMove, self)._get_new_picking_values()
values = super()._get_new_picking_values()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my opinion, it's not necessary to override this function. we have a constraint to make sure the order and its warehouse having the same value of operating_unit_id. So, just let the field stock_picking.operating_unit_id computes the value itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operating unit is not mandatory on the warehouse and then you could have a shared warehouse and having pickings from several operating units. In that case, the compute will not work.

sale_stock_operating_unit/models/stock_warehouse.py
("warehouse_id", "=", rec.id),
("operating_unit_id", "!=", rec.operating_unit_id.id),
]
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add limit=1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-sale_stock_operating_unit branch from 32858c8 to fe9a73d Compare June 24, 2024 13:43
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-sale_stock_operating_unit branch from fe9a73d to 307da6e Compare August 2, 2024 12:51
@yvaucher
Copy link
Member

yvaucher commented Aug 5, 2024

All dependencies have been merge, please refresh the PR by removing the test-requirement change.

yvaucher
yvaucher approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sudhir-serpentcs and others added 20 commits August 7, 2024 13:47
@sudhir-serpentcs @jdidderen-nsi
Added Sale Stock OU module for v8.
b339265
@sudhir-serpentcs @jdidderen-nsi
Migrated Sale Stock OU module from v7 to v8.
66165e5
@sudhir-serpentcs @jdidderen-nsi
Added Test cases and Readme file.
b189b09
@AaronHForgeFlow @jdidderen-nsi
Migrate to v9
3264b71
@LoisRForgeFlow @jdidderen-nsi
[MIG] sale_stock_operating_unit to v10.
d9d6f54
@guewen @jdidderen-nsi
Fix constraint on warehouses (OCA#61)
fde8c65
@AaronHForgeFlow @jdidderen-nsi
[FIX]team operating unit has more priority than the default warehouse
ed6d0ce 
od the company

[FIX]access operating unit of the sales team
@bjeficent @jdidderen-nsi
[MIG] sale_stock_operating_unit: Migration to v12
2145497
@oca-travis @jdidderen-nsi
[UPD] Update sale_stock_operating_unit.pot
c521d92
@OCA-git-bot @jdidderen-nsi
[UPD] README.rst
94ec5e7
@osi-scampbell @jdidderen-nsi
[IMP] Sale Multi Ware
bc4c7b5
@oca-travis @jdidderen-nsi
[UPD] Update sale_stock_operating_unit.pot
9547ced
@OCA-git-bot @jdidderen-nsi
sale_stock_operating_unit 12.0.1.0.1
aa18a72
@pedrocs-exo @jdidderen-nsi
Added translation using Weblate (Portuguese)
073fd75
@pedrocs-exo @jdidderen-nsi
Translated using Weblate (Portuguese)
82557bd 
Currently translated at 100.0% (5 of 5 strings)

Translation: operating-unit-12.0/operating-unit-12.0-sale_stock_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-12-0/operating-unit-12-0-sale_stock_operating_unit/pt/
@francesco-ooops @jdidderen-nsi
Added translation using Weblate (Italian)
33f0603
@francesco-ooops @jdidderen-nsi
Translated using Weblate (Italian)
8bbca3e 
Currently translated at 100.0% (5 of 5 strings)

Translation: operating-unit-12.0/operating-unit-12.0-sale_stock_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-12-0/operating-unit-12-0-sale_stock_operating_unit/it/
@jdidderen-nsi
[IMP] sale_stock_operating_unit: black, isort, prettier
33e8e32
@jdidderen-nsi
[15.0][MIG] sale_stock_operating_unit: Migration to 15.0
5adce0d
@jdidderen-nsi
[UPD] Update sale_stock_operating_unit.pot
dc8b16d
OCA-git-bot and others added 7 commits August 7, 2024 13:47
@OCA-git-bot @jdidderen-nsi
[UPD] README.rst
49cfb62
@weblate @jdidderen-nsi
Update translation files
14fd053 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: operating-unit-15.0/operating-unit-15.0-sale_stock_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-sale_stock_operating_unit/
@mymage @jdidderen-nsi
Translated using Weblate (Italian)
41f7b36 
Currently translated at 80.0% (4 of 5 strings)

Translation: operating-unit-15.0/operating-unit-15.0-sale_stock_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-sale_stock_operating_unit/it/
@OCA-git-bot @jdidderen-nsi
[UPD] README.rst
2b8193b
@mymage @jdidderen-nsi
Translated using Weblate (Italian)
8c11e8b 
Currently translated at 100.0% (5 of 5 strings)

Translation: operating-unit-15.0/operating-unit-15.0-sale_stock_operating_unit
Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-sale_stock_operating_unit/it/
@jdidderen-nsi
[IMP] sale_stock_operating_unit: pre-commit execution
50a2ce4
@jdidderen-nsi
[MIG] sale_stock_operating_unit: Migration to 17.0
a968b41
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-sale_stock_operating_unit branch from 307da6e to a968b41 Compare August 7, 2024 11:47
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-676-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cb58499 into OCA:17.0 Aug 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 018904c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher approved these changes

@nguyenminhchien nguyenminhchien nguyenminhchien approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.