Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_financial_report_operating_unit : Migration to 17.0 #686

Merged
merged 13 commits into from
Aug 6, 2024
Merged

[17.0][MIG] account_financial_report_operating_unit : Migration to 17.0 #686

merged 13 commits into from
Aug 6, 2024

Conversation

traitrantrobz
Copy link

@traitrantrobz traitrantrobz commented Jun 18, 2024 •
edited by yvaucher
Loading

@traitrantrobz traitrantrobz force-pushed the 17.0-mig-account_financial_report_operating_unit branch 3 times, most recently from a017e88 to d84f8fc Compare June 18, 2024 08:10
@traitrantrobz traitrantrobz force-pushed the 17.0-mig-account_financial_report_operating_unit branch from d84f8fc to f81983f Compare June 18, 2024 08:14
@traitrantrobz traitrantrobz marked this pull request as ready for review June 18, 2024 10:13
leemannd
leemannd approved these changes Jun 27, 2024
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. There are no unit tests for the moment

@traitrantrobz traitrantrobz mentioned this pull request Jul 29, 2024
Open
16 tasks
@yankinmax
Copy link

@traitrantrobz can you pls remove dependency commit and rebase?

@traitrantrobz traitrantrobz force-pushed the 17.0-mig-account_financial_report_operating_unit branch from f81983f to 0eab7e1 Compare August 6, 2024 03:37
yankinmax
yankinmax reviewed Aug 6, 2024
View reviewed changes
account_financial_report_operating_unit/report/open_items.py
@@ -13,10 +13,10 @@ def _get_report_values(self, docids, data):

@api.model
def _get_move_lines_domain_not_reconciled(
self, company_id, account_ids, partner_ids, target_move, date_from
self, company_id, account_ids, partner_ids, only_posted_moves, date_from
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankinmax I want to synchronize the parameter names of the original function.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-686-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 6, 2024
@OCA-git-bot
Merge PR #686 into 17.0
0e50c70 
Signed-off-by AaronHForgeFlow
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-686-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2d938f7 into OCA:17.0 Aug 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8850ad0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankinmax yankinmax yankinmax approved these changes

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@traitrantrobz @yankinmax @OCA-git-bot @AaronHForgeFlow @leemannd @kittiu @oca-travis @ps-tubtim @newtratip