Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] pos_operating_unit: Migration to 17.0 #693

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

jdidderen-nsi
Copy link
Contributor

No description provided.

@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-pos_operating_unit branch 2 times, most recently from 50c7fa2 to bc90509 Compare July 2, 2024 21:35
@jdidderen-nsi jdidderen-nsi marked this pull request as ready for review July 2, 2024 21:43
@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-pos_operating_unit branch 3 times, most recently from 0eafb6f to cbafbb4 Compare July 2, 2024 22:45
Comment on lines +9 to +13
<setting
id="operating_units_setting"
string="Operating Units"
help="Operating units used for this POS"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdidderen-nsi Why remove groups?

Copy link
Contributor Author

@jdidderen-nsi jdidderen-nsi Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For no reason, a simple mistake when copying example from standard Odoo.
I added the groups on every operating_unit_id(s) field to fit with other OU modules

@traitrantrobz
Copy link

Exception review, everything else is LGTM!

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-693-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3838ddf into OCA:17.0 Aug 29, 2024
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1b94b0b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants