Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][ADD] mail_operating_unit: new module #697

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[17.0][ADD] mail_operating_unit: new module #697

merged 1 commit into from
Aug 14, 2024

Conversation

vvrossem
Copy link

No description provided.

@vvrossem vvrossem marked this pull request as draft July 17, 2024 08:24
@vvrossem vvrossem force-pushed the 17.0-add-mail_operating_unit branch 2 times, most recently from 9e23361 to eee9944 Compare July 17, 2024 09:44
@vvrossem vvrossem changed the title [ADD] mail_operating_unit: new module [17.0][ADD] mail_operating_unit: new module Jul 17, 2024
@vvrossem vvrossem marked this pull request as ready for review July 17, 2024 09:49
gurneyalex
gurneyalex reviewed Jul 18, 2024
View reviewed changes
mail_operating_unit/models/mail_thread.py Outdated Show resolved Hide resolved
mail_operating_unit/models/models.py Show resolved Hide resolved
mail_operating_unit/models/models.py Outdated Show resolved Hide resolved
mail_operating_unit/models/models.py Show resolved Hide resolved
@vvrossem vvrossem force-pushed the 17.0-add-mail_operating_unit branch 3 times, most recently from 021e349 to 936b406 Compare July 19, 2024 13:48
Camille0907
Camille0907 approved these changes Aug 8, 2024
View reviewed changes
Copy link

@Camille0907 Camille0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nitpicking on a few points only 🙂

mail_operating_unit/models/mail_template.py Outdated Show resolved Hide resolved
mail_operating_unit/models/models.py Outdated Show resolved Hide resolved
mail_operating_unit/tests/test_fake_partner_mail_operating_unit.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yankinmax
Copy link

@vvrossem can you pls address @Camille0907 suggestions?

@vvrossem vvrossem force-pushed the 17.0-add-mail_operating_unit branch from 936b406 to d49b777 Compare August 13, 2024 12:14
@yankinmax
Copy link

@AaronHForgeFlow can you pls take a look here and push merge?

@vvrossem vvrossem force-pushed the 17.0-add-mail_operating_unit branch from d49b777 to 5926684 Compare August 14, 2024 08:37
@vvrossem
Copy link
Author

thank you for reviewing @simahawk 🧡

@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-697-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b269de8 into OCA:17.0 Aug 14, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b81031c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex left review comments

@yankinmax yankinmax yankinmax approved these changes

@simahawk simahawk simahawk approved these changes

@Camille0907 Camille0907 Camille0907 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vvrossem @OCA-git-bot @yankinmax @simahawk @gurneyalex @Camille0907