Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] crm_partner_company_group: show company_group_id on list and form view #1949

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

CRogos
Copy link

@CRogos CRogos commented Jan 3, 2025

No description provided.

@CRogos CRogos force-pushed the 17.0-imp-crm_partner_company_group branch from 3771189 to 2f92641 Compare January 3, 2025 09:41
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runboat, LGTM

@CRogos
Copy link
Author

CRogos commented Feb 6, 2025

@nguyenminhchien would you be so kind and do the second review of this improvement?

>
<field
name="company_group_id"
readonly="1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly="1"

It's readonly by default of related field

>
<field
name="company_group_id"
readonly="1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
readonly="1"

@CRogos CRogos force-pushed the 17.0-imp-crm_partner_company_group branch from 2f92641 to 560d48c Compare February 7, 2025 08:12
@CRogos CRogos force-pushed the 17.0-imp-crm_partner_company_group branch from 560d48c to f74e679 Compare February 7, 2025 08:18
Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants