[16.0][IMP] partner_multi_relation: allow to archive relation types#2200
Conversation
NL66278
left a comment
There was a problem hiding this comment.
👍 Thank you for your contribution, but could you also modify the views to allow archiving, unarchiving and filtering?
|
Hi @NL66278 : archiving and unarchiving is allowed by default in Odoo v16 as soon as you add the Note that I'll however change this PR state to draft because archived relation types are still useable on res.partner.relation records, which should be avoided. However I don't have time to work on it right now. |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@NL66278 This was not ready |
|
Congratulations, your PR was merged at 69f144b. Thanks a lot for contributing to OCA. ❤️ |
|
@NL66278 As I told you yesterday, this is not ready since it is still possible to create, from the UI, relations with archived relation types. Hence this adding is useless. This is why I changed my PR state to draft ... |
|
@marielejeune You can add the additional code later and if OK I will merge it as well. |
Ok but I don't see the point of merging something that is useless and doesn't work. If some people try to use the module because they see it available, they won't understand why it doesn't work ... |
Basic improvements to make it possible to archive relation types.
If this PR is once approved, I can forward-port it to higher versions.
NB: I've no idea why a test that is not related to my change is failing. If someone can help, feel free.