Skip to content

[16.0][IMP] partner_multi_relation: allow to archive relation types#2200

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-partner_multi_relation_type_archive-mle
Nov 26, 2025
Merged

[16.0][IMP] partner_multi_relation: allow to archive relation types#2200
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-partner_multi_relation_type_archive-mle

Conversation

@marielejeune

@marielejeune marielejeune commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Basic improvements to make it possible to archive relation types.

If this PR is once approved, I can forward-port it to higher versions.

NB: I've no idea why a test that is not related to my change is failing. If someone can help, feel free.

@NL66278 NL66278 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for your contribution, but could you also modify the views to allow archiving, unarchiving and filtering?

@marielejeune

Copy link
Copy Markdown
Contributor Author

Hi @NL66278 : archiving and unarchiving is allowed by default in Odoo v16 as soon as you add the active field.
Concerning the filtering, this is not done but it is easy to create a custom filter and save it in your preferences if you need it.

Note that I'll however change this PR state to draft because archived relation types are still useable on res.partner.relation records, which should be avoided. However I don't have time to work on it right now.
Feel free to contribute if you need this. Thanks

@marielejeune marielejeune marked this pull request as draft November 25, 2025 07:21
@NL66278

NL66278 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2200-by-NL66278-bump-minor, awaiting test results.

@rousseldenis

Copy link
Copy Markdown
Contributor

@NL66278 This was not ready

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 69f144b. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 54edcc4 into OCA:16.0 Nov 26, 2025
8 of 9 checks passed
@marielejeune

Copy link
Copy Markdown
Contributor Author

@NL66278 As I told you yesterday, this is not ready since it is still possible to create, from the UI, relations with archived relation types. Hence this adding is useless. This is why I changed my PR state to draft ...

@NL66278

NL66278 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

@marielejeune You can add the additional code later and if OK I will merge it as well.

@marielejeune

Copy link
Copy Markdown
Contributor Author

@marielejeune You can add the additional code later and if OK I will merge it as well.

Ok but I don't see the point of merging something that is useless and doesn't work. If some people try to use the module because they see it available, they won't understand why it doesn't work ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants