[18.0][MIG] product_attribute_custom_variant

[rousseldenis]

Based on :

• [ADD] product_attribute_custom_value_variant #1839

See related module : OCA/sale-workflow#3631

[rousseldenis]

/ocabot migration product_attribute_custom_variant

[rousseldenis]

@SirAionTech This can be your interest.

I've added two improvements you can maybe backport to your PR.

[rousseldenis]

@monen17

[rousseldenis]

I think the sale part can be splitted.

[monen17]

Thanks for the PR!
I have tried this module in a local instance and it works great!

I also have reviewed the code and noticed a few thinkgs, see the other comments.

Please edit the title of commit 38ddd11 because it's too long according to the guidelines:

please check if the commit message is cut with ellipsis

(from https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message)

and gets truncated:

Since the module name consumes a lot of space already, you can either shorten it or the commit description with something like:

[IMP] product_attribute_custom_value_variant: Readability

Split code in functions

One more thought: it might also be a [REF] because the module's behavior is not changing.

About the backporting, I prefer to do such things when PRs are merged for two reasons:

• avoid the overhead of keeping multiple PRs synced
• one more reason to merge PRs 😏

---

I think the sale part can be splitted.

I agree that ideally this module would only depend on product and we'd have a bridge module to make it work with sale, but as far as I know custom attribute values have very little (maybe none?) use without sales so the bridge module would be installed very often making the decoupling useless.
This said, if someone wants to do it it's ok by me.

[rousseldenis]

About the backporting, I prefer to do such things when PRs are merged for two reasons:

• avoid the overhead of keeping multiple PRs synced
• one more reason to merge PRs 😏

Yes, I approved your 16.0's PR. If you can attract people there, we can merge :-)

[rousseldenis]

I agree that ideally this module would only depend on product and we'd have a bridge module to make it work with sale, but as far as I know custom attribute values have very little (maybe none?) use without sales so the bridge module would be installed very often making the decoupling useless.
This said, if someone wants to do it it's ok by me.

I will publish the split here soon. The idea was also to simplify the code to be called on sale side in order to replace the variant by the new one.

The idea was to be able to get new variant from custom attribute in any other flow.

[rousseldenis]

(from https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message)

and gets truncated:

I agree with short commit message BUT I'm not with non meaning ones. And that's not because github interface truncates it that they should go to something like [IMP] p_a_c_v: (...) 😅

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.