[18.0] [MIG] product_configurator: Migration to 18.0 #150

bizzappdev · 2025-02-13T07:30:49Z

No description provided.

…ct_configurator_purchase : create test case for after or before validate the product then it id or sol is equal or not

…g file

…late and product functionality

…vals_dict method

…ids method

…duct_weight_extra method

…bute method

…est case

…duct config and product product

…bute and compute_domain and solved the error come in _check_constraint_min_max_value method

…g them in website module

Make it classmethod to reuse it at every test setup step.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-configurator-16.0/product-configurator-16.0-product_configurator Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-configurator-17.0/product-configurator-17.0-product_configurator Translate-URL: https://translation.odoo-community.org/projects/product-configurator-17-0/product-configurator-17-0-product_configurator/

Currently translated at 100.0% (235 of 235 strings) Translation: product-configurator-17.0/product-configurator-17.0-product_configurator Translate-URL: https://translation.odoo-community.org/projects/product-configurator-17-0/product-configurator-17-0-product_configurator/it/

ivantodorovich

Thanks for the work done! 🙏🏻

ivantodorovich · 2025-02-17T14:32:26Z

product_configurator/models/product_config.py

@@ -421,7 +422,10 @@ def get_cfg_weight(self, value_ids=None, custom_vals=None):

        self = self.with_context(active_id=product_tmpl.id)

-        value_ids = flatten(value_ids)
+        # Use the updated flatten method (using itertools.chain)


Suggested change

# Use the updated flatten method (using itertools.chain)

no need to clarify this in the code

ivantodorovich · 2025-02-17T14:39:04Z

product_configurator/models/product_config.py

-        value_ids = flatten(value_ids)
+        # Use the updated flatten method (using itertools.chain)
+        value_ids = list(
+            chain.from_iterable(v if isinstance(v, list) else [v] for v in value_ids)


Consider also other iterables (ie: tuple)

from collections.abc import Iterable

Suggested change

chain.from_iterable(v if isinstance(v, list) else [v] for v in value_ids)

chain.from_iterable(v if isinstance(v, Iterable) else [v] for v in value_ids)

ivantodorovich · 2025-02-17T14:39:57Z

product_configurator/models/product_config.py

@@ -504,8 +508,6 @@ def _compute_currency_id(self):
    product_preset_id = fields.Many2one(
        comodel_name="product.product",
        string="Preset",
-        domain="[('product_tmpl_id', '=', product_tmpl_id),\
-            ('config_preset_ok', '=', True)]",


What's the motivation for removing the domain here and moving it to the view? 🤔

We will have to move the domain to the level of XML
As in v18, domains based on related fields are not carried forward. https://github.com/odoo/odoo/blob/18.0/odoo/fields.py#L3067
product_preset_id field is defined at the product.config.session level and the product.configurator inherits the original object. Which makes that field related.

ivantodorovich · 2025-02-17T14:42:54Z

product_configurator/models/product_config.py

-        open_step_lines = list(
-            map(lambda x: "%s" % (x), self.get_open_step_lines().ids)
-        )
+        open_step_lines = list(map(lambda x: f"{x}", self.get_open_step_lines().ids))


Suggested change

open_step_lines = list(map(lambda x: f"{x}", self.get_open_step_lines().ids))

open_step_lines = list(map(str, self.get_open_step_lines().ids))

ivantodorovich · 2025-02-17T14:43:47Z

product_configurator/models/product_config.py

@@ -1173,7 +1173,7 @@ def check_and_open_incomplete_step(self, value_ids=None, custom_value_ids=None):
                step_to_open = step
                break
        if step_to_open:
-            return "%s" % (step_to_open.id)
+            return f"{step_to_open.id}"


str(step_to_open.id)

ivantodorovich · 2025-02-17T15:10:45Z

product_configurator/static/src/scss/form_widget.scss

+    }
+}
+
+.pull-right {


We can just use bootstrap's float-end class and remove this one

ivantodorovich · 2025-02-17T15:11:55Z

product_configurator/wizard/product_configurator.py

+
+from lxml import etree
+
+from odoo import _, api, fields, models


Use self.env._ instead

ivantodorovich · 2025-02-17T15:14:55Z

product_configurator/models/product_attribute.py

+
+        TODO: This only works when activating the selection not when typing
+        """
+        product_tmpl_id = self.env.context.get("_cfg_product_tmpl_id")


Can we take the opportunity to write unit tests for this method? 🙏🏻

We take care of the test cases also in this MR

ivantodorovich · 2025-02-17T15:20:30Z

product_configurator/models/product_config.py

+        ]
+        return prices
+
+    def encode_custom_values(self, custom_vals):


Is this method actually used somewhere? 🤔
if not, let's remove it

ivantodorovich · 2025-02-17T15:21:14Z

product_configurator/models/product_config.py

+        )
+        return list(flat_val_ids)
+
+    def formatPrices(self, prices=None, dp="Product Price"):


Is this method actually used somewhere? 🤔
if not, let's remove it

In the core modules, it is not used, But I still remember some of the custom modules and other companies were also using this method in their modules.

bizzappdev · 2025-02-19T14:28:32Z

@ivantodorovich Thank you so much for your review and for pointing out the missing points and improvements. We have made the necessary changes.

Pooja Khandelwal and others added 30 commits February 3, 2025 11:30

[ADD][#T00513] product_configurator_sale, product_configurator, produ…

9e07b0f

…ct_configurator_purchase : create test case for after or before validate the product then it id or sol is equal or not

[FIX]add value_ids in depends

22e7633

[ADD][#T00513]product_configurator:create test case for product_confi…

9215d61

…g file

[WIP][#T00513] write test-case for product template

ceef08a

[IMP]price and weight on website

32db44c

[IMP][#T00513] product_configurator: write test-case for product_temp…

33a9e58

…late and product functionality

[IMP][#T00513]product_configurator: create test case for _get_custom_…

f10446b

…vals_dict method

[IMP][#T00513]product_configurator:create test case for _check_value_…

3b7c70c

…ids method

[FIX]fix record rules

900e35f

[FIX]set value_ids only if value_ids is None

afc0c73

[IMP][#T00513]product_configurator: create test case for _compute_pro…

6a75c0e

…duct_weight_extra method

[IMP][#T00513]product_configurator: remove comment statement

9f90773

[FIX]uncommit button config_ok

09bd899

[IMP][#T00513]product_configurator: create test case for unique_attri…

b39f6af

…bute method

[ADD][t00513]product_configurator,product_configurator_stock: write t…

0e0a6d2

…est case

[T-00513][IMP] product_configurator: For test-case add changes in pro…

cbc8a3a

…duct config and product product

[ADD][#T00513]product_configurator:solved conflict

b7718e9

[FIX]move .get_custom_value_id to config session

f70b407

[T-00513][IMP] add new changes

5873860

[FIX]fix flake8 and pylint errors

ef2ea9a

[ADD][#T00513]product_configurator: create test case for unique_attri…

05525a7

…bute and compute_domain and solved the error come in _check_constraint_min_max_value method

[FIX]call get_custom_value using config_session

4a5adc2

[FIX]fix flake8

254c132

[FIX]change realtion and columns name in value_ids

ddff42d

[FIX][T-00513] product_configurator: add new changes and fix some issue

d4102d4

[IMP][T-00513] product_configurator: solve flake8

f83ca74

[FIX]add domain website_published = true in record rules by inheritin…

dfbe790

…g them in website module

[WIP]initial working wizard for the v12 migration

ab15ebd

[FIX]remove noupdate=1 from security file of product_configurator

ba355d7

[IMP]make image click work for radio and check box

dd61ac0

simahawk and others added 19 commits February 3, 2025 11:30

product_configurator: restore test_wizard

0991c94

product_configurator: improve test _configure_product_nxt_step

03bb556

Make it classmethod to reuse it at every test setup step.

product_configurator: restore test_product_config

4152b65

product_configurator: add fixme comment on test_product

dd39a58

product_configurator: restore test_product_attribute

2f53869

product_configurator: restore test_create

ff2dab3

[UPD] Update product_configurator.pot

61df1dc

[BOT] post-merge updates

7fcd335

product_configurator: make not installable

b12a6a2

[IMP] product_configurator: pre-commit auto fixes

59b1e83

[MIG] product_configurator: Migration to 17.0

a6e9798

[UPD] Update product_configurator.pot

25e545b

[BOT] post-merge updates

4c1b5fd

product_configurator : Fixed warning product_configurator module.

dbc54c3

[BOT] post-merge updates

c6c0fbd

[IMP] product_configurator: pre-commit auto fixes

f74a867

bizzappdev force-pushed the 18.0-mig-product_configurator-BAD branch from 5bf3c75 to 439b635 Compare February 13, 2025 08:23

bizzappdev mentioned this pull request Feb 13, 2025

[18.0] [MIG] product_configurator_sale: Migration to 18.0 #151

Open

bizzappdev marked this pull request as ready for review February 14, 2025 08:02

ivantodorovich reviewed Feb 17, 2025

View reviewed changes

bizzappdev marked this pull request as draft February 18, 2025 05:53

bizzappdev force-pushed the 18.0-mig-product_configurator-BAD branch 2 times, most recently from b52aeff to 5faec59 Compare February 19, 2025 10:22

[MIG] product_configurator: Migration to 18.0

16a3618

bizzappdev force-pushed the 18.0-mig-product_configurator-BAD branch from 5faec59 to 16a3618 Compare February 19, 2025 14:24

bizzappdev marked this pull request as ready for review February 19, 2025 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0] [MIG] product_configurator: Migration to 18.0 #150

[18.0] [MIG] product_configurator: Migration to 18.0 #150

bizzappdev commented Feb 13, 2025

ivantodorovich left a comment

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025 •

edited

Loading

bizzappdev Feb 19, 2025

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025

bizzappdev Feb 19, 2025

ivantodorovich Feb 17, 2025

ivantodorovich Feb 17, 2025

bizzappdev Feb 19, 2025

bizzappdev commented Feb 19, 2025

	chain.from_iterable(v if isinstance(v, list) else [v] for v in value_ids)
	chain.from_iterable(v if isinstance(v, Iterable) else [v] for v in value_ids)

	open_step_lines = list(map(lambda x: f"{x}", self.get_open_step_lines().ids))
	open_step_lines = list(map(str, self.get_open_step_lines().ids))


		from lxml import etree

		from odoo import _, api, fields, models

[18.0] [MIG] product_configurator: Migration to 18.0 #150

Are you sure you want to change the base?

[18.0] [MIG] product_configurator: Migration to 18.0 #150

Conversation

bizzappdev commented Feb 13, 2025

ivantodorovich left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivantodorovich Feb 17, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bizzappdev commented Feb 19, 2025

ivantodorovich Feb 17, 2025 •

edited

Loading