-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD] product_pack_category_restriction #136
[13.0][ADD] product_pack_category_restriction #136
Conversation
bfd00da
to
c8ffa63
Compare
Hi @ernestotejeda and @pedrobaeza Could I get your feedback on this new module? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think a better name would be |
c8ffa63
to
0d0b6bb
Compare
I agree @pedrobaeza, name has been now changed. Thank you for the feedback :) |
.copier-answers.yml
Outdated
@@ -14,7 +14,8 @@ include_wkhtmltopdf: false | |||
odoo_version: 13.0 | |||
org_name: Odoo Community Association (OCA) | |||
org_slug: OCA | |||
rebel_module_groups: [] | |||
rebel_module_groups: | |||
- product_pack_category_restriction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't put this. The defaults should be compatible (see later).
0d0b6bb
to
bda23d4
Compare
Makes sense @pedrobaeza , thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at df8bc74. Thanks a lot for contributing to OCA. ❤️ |
Module to restrict pack products to specific product categories.