Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] product_pack_category_restriction #136

Merged

Conversation

JordiMForgeFlow
Copy link

Module to restrict pack products to specific product categories.

@JordiMForgeFlow JordiMForgeFlow force-pushed the 13.0-add-product_pack_product_category branch 4 times, most recently from bfd00da to c8ffa63 Compare June 29, 2023 08:51
@JordiMForgeFlow
Copy link
Author

Hi @ernestotejeda and @pedrobaeza

Could I get your feedback on this new module? :)

Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

I think a better name would be product_pack_category_restriction

@JordiMForgeFlow JordiMForgeFlow force-pushed the 13.0-add-product_pack_product_category branch from c8ffa63 to 0d0b6bb Compare June 30, 2023 04:02
@JordiMForgeFlow JordiMForgeFlow changed the title [13.0][ADD] product_pack_product_category [13.0][ADD] product_pack_category_restriction Jun 30, 2023
@JordiMForgeFlow
Copy link
Author

I agree @pedrobaeza, name has been now changed. Thank you for the feedback :)

@@ -14,7 +14,8 @@ include_wkhtmltopdf: false
odoo_version: 13.0
org_name: Odoo Community Association (OCA)
org_slug: OCA
rebel_module_groups: []
rebel_module_groups:
- product_pack_category_restriction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put this. The defaults should be compatible (see later).

@pedrobaeza pedrobaeza added this to the 13.0 milestone Jun 30, 2023
@JordiMForgeFlow JordiMForgeFlow force-pushed the 13.0-add-product_pack_product_category branch from 0d0b6bb to bda23d4 Compare June 30, 2023 06:46
@JordiMForgeFlow
Copy link
Author

Makes sense @pedrobaeza , thanks!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-136-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c53ce45 into OCA:13.0 Jun 30, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at df8bc74. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-add-product_pack_product_category branch July 3, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants