[16.0][FIX] sale_product_pack: keep order lines in order #141
Conversation
|
Hi @ernestotejeda, |
pedrobaeza
changed the title
| @@ -84,8 +84,7 @@ def create(self, vals_list): | |||
| line.expand_pack_line() | |||
| res |= line | |||
| else: | |||
| new_vals.append(elem) | |||
| res |= super().create(new_vals) | |||
| res |= super().create([elem]) | |||
There was a problem hiding this comment.
This is incorrect, as it's serializing the creation. If you want to keep order, play with other things like sequence, but I don't understand why they aren't properly ordered already. Please include steps to reproduce the problem.
There was a problem hiding this comment.
Hi! I added the steps to reproduce error and a video on description
There was a problem hiding this comment.
The video is not shown, but as said, the solution for the problem shouldn't be to serialize the creation.
There was a problem hiding this comment.
Hi @pedrobaeza I made some changes!
augusto-weiss
force-pushed
the
16.0-h-63333-awe
branch
from
cd538f0
to
10b9311
Compare
|
|
||
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| new_vals = [] | ||
| res = self.browse() | ||
| for elem in vals_list: | ||
| for idx, elem in enumerate(vals_list): | ||
| elem["sequence"] = idx |
There was a problem hiding this comment.
Why doing it here? Prepare the sequence on expand_pack_line, summing the main line sequence + an incremental number
There was a problem hiding this comment.
All sale order lines have the same sequence (equal 10).
Editing the component lines also broke the sequence when you have some order lines added.
Example:
sale order line 1 (sequence = 10)
sale order line 2 (sequence = 10) -> pack detailled
sale order line 3 (sequence = 10)
Computed:
sale order line 1 (sequence = 10)
sale order line 2 (sequence = 10) -> pack detailed
Component 1 (sequence = 11)
Component 2 (sequence = 12)
sale order line 3 (sequence = 10)
Output result:
sale order line 1 (sequence = 10)
sale order line 2 (sequence = 10) -> pack detailled
sale order line 3 (sequence = 10)
Component 1 (sequence = 11)
Component 2 (sequence = 12)
There was a problem hiding this comment.
Otherside, i must make some change, adding a context because every case have a different behaivour
There was a problem hiding this comment.
This is still not correct, as you can make the create of the sales order lines on several batches, so you must check the resequence mechanism implemented in this version, and hook it to respect the relative pack lines orders.
augusto-weiss
force-pushed
the
16.0-h-63333-awe
branch
from
10b9311
to
e98cd8e
Compare
augusto-weiss
force-pushed
the
16.0-h-63333-awe
branch
from
e98cd8e
to
8e916cd
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
The issue:
When add diferent sale orders, packs and their components are added first, and then the other order lines
To reproduce the error:
New sale order
(1) Add a sale order line
(2) Add a sale order line (pack)
Save the sale order
Behavior before this PR:
The sale order will show:
(2) The pack sale order line and components first
(1) The other sale order line
Behavior after this PR:
Hold the order of sale order lines 1 and 2
Untitled_.Aug.4.2023.3_14.PM.webm