-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] product_pack: Migration to 17.0 #154
Conversation
IMP product pack to support surveyor packs IMP pack description IMP add product pack standar functionality for v8 and general improvements IMP discounts and portal distributors permissions FIX product_pack license and author FIX prod pack available IMP pack to restrict company in products FIX pack company restriction
IMP product_pack format FIX fix_digits_compute_to_digits IMP IMPORTANT imprrovements on product pack, get pack with sale order constraint IMP use constraint on sale line and not sale order for product packs IMP implement totalice price on product pack IMP update pack manifest FIX prod pack copy sale order FIX contraint IMP compt with other modules FIX prod pack @api.multi
9.0 FIX filter the taxes by company (OCA#111)
* [REL] replace __openerp__ for __manifest__ * [REL] replace openerp imports for odoo * [REL] some python3 exceptions * [REL] replace openerp by odoo on xml files * [REL] delete utf-8 line on python files * [REL] some minor fixes for migration to v11 * [FIX] runbot link
* [FIX] xml files names * [REL] migration product_pack to 11.0 * [FIX] Update README * [FIX] remove openerp tags and data tags * [IMP] change some funtion to improve funcionality * [FIX] change name to xml and .py files according guidelines * [FIX] remove api.one decorators * [FIX] update readme * [FIX] Remove "encoding: utf-8" * [FIX] remove api.multi, string not necesary and some other fixes * [FIX] demo data to separate according Guidelines * [FIX] fix names in fields * [FIX] remove executable
* [ADD] product_pack: Add compatibility with website_sale. * [ADD] product_pack: Allow product pack modify * [ADD] product_pack: In sale order do not let to delete/modify a line that belongs to a pack * [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in product. * [ADD] product_pack: Do not compute price in cart for components_price packs [FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187) * [FIX] product_pack: Pack line price fixed (take into account pricelist) Proper compute pack line price using price instead of list_price * [FIX] product_pack: Allow Modidy Pack only showed for Components price packs * [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if needed.
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (OCA#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
… the type 'fixed and totalice' (#203)
Currently translated at 95.6% (43 of 45 strings) Translation: product-pack-12.0/product-pack-12.0-product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-product_pack/pt/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Functional review
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-154-by-gurneyalex-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aborted. @gurneyalex please check first the contents before merging, as there's a binary of 30 MB included in this PR: pandoc-3.1.9-1-amd64.deb
Hey @pedrobaeza @gurneyalex I that binary was added after pre-commit execution (7d81a85), not sure why... should I remove it? |
there are ongoing FIX PR´s for product_pack and website_sale_product_pack. For product_pack its just a small change but i think we should consider it in the migratroin to 17. |
Yes, you should remove it. That should be something of pre-commit not cleaning caches. |
85b9c7a
to
7ec7bcd
Compare
@pedrobaeza done! @NICO-SOLUTIONS if the PRs are still open I think it is better to merge this migration as it is and then when the solution is merge in 16 make the forward port to 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
On my way to merge this fine PR! |
This PR has the |
Congratulations, your PR was merged at b99e1de. Thanks a lot for contributing to OCA. ❤️ |
No description provided.