Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] website_sale_product_pack: Migration to 16.0 #165

Merged
merged 15 commits into from
Apr 10, 2024
Merged

[16.0][FIX] website_sale_product_pack: Migration to 16.0 #165

merged 15 commits into from
Apr 10, 2024

Conversation

lef-adhoc
Copy link

This is a continuation of the pr #135
See more info here

chienandalu and others added 13 commits June 6, 2023 13:14
@chienandalu @alvaro-domatix
[ADD] website_sale_product_pack: New module
0679726 
Compatibility module between sale_product_pack and website_sale

TT30385
@chienandalu @alvaro-domatix
[FIX] stock_product_pack: get already computed values if existing
f1ecd9d 
Done for e-commerce compatibility purposes, althoug it's more performant
indeed.
@oca-travis @alvaro-domatix
[UPD] Update website_sale_product_pack.pot
a86f73a
@OCA-git-bot @alvaro-domatix
[UPD] README.rst
4a6f728
@OCA-git-bot @alvaro-domatix
[ADD] icon.png
76089e8
@pedrobaeza @alvaro-domatix
[FIX] website_sale_product_pack: Resilient tests
ed85de3 
Create and select a specific pricelist for avoiding problems in
integrated environments where the default pricelist currency has been
changed.
@chienandalu @alvaro-domatix
Set portal user pricelist
eb1bf26
@chienandalu @alvaro-domatix
[FIX] website_sale_product_pack: detailed totalized packs
7070308 
When the cart is confirmed, a price recalculation is triggered for every
order line. This is wrong for detailed totalized packs, which lines
should be at 0.

TT38186
@OCA-git-bot @alvaro-domatix
website_sale_product_pack 13.0.1.0.1
84b86f6
@OCA-git-bot @alvaro-domatix
website_sale_product_pack 13.0.1.0.2
05d4490
@OCA-git-bot @alvaro-domatix
[IMP] website_sale_product_pack: Published and unpublished for produc…
4ab2da0 
…ts using packs
@alvaro-domatix
[UPD] Update website_sale_product_pack.pot
87c9f7d
@OCA-git-bot @alvaro-domatix
[UPD] README.rst
f4afb50
ioans73
ioans73 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ioans73 ioans73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ioans73
Copy link
Member

ioans73 commented Mar 27, 2024

@OCA/product-maintainers could you review this? (is a continuation of the pr #135)

cc @alvaro-domatix

NICO-SOLUTIONS
NICO-SOLUTIONS reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@NICO-SOLUTIONS NICO-SOLUTIONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioans73
Copy link
Member

ioans73 commented Mar 27, 2024

LGTM

@NICO-SOLUTIONS can you approve?

@ioans73
Copy link
Member

ioans73 commented Apr 4, 2024

@pedrobaeza Could we merge this?

@pedrobaeza pedrobaeza mentioned this pull request Apr 4, 2024
Closed
@pedrobaeza pedrobaeza changed the title [16.0][FIX] website_sale_product_pack: Fixed KeyError: 'product_id' error due to Odoo making changes. [16.0][FIX] website_sale_product_pack: Migration to 16.0 Apr 4, 2024
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_product_pack

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 4, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#101) has not been updated to reference the current pull request because a previous pull request (#135) is not closed.
Perhaps you should check that there is no duplicate work.
CC @alvaro-domatix

@pedrobaeza
Copy link
Member

/ocabot migration website_sale_product_pack

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 4, 2024
Open
5 tasks
pedrobaeza
pedrobaeza reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chienandalu is it OK for you?

website_sale_product_pack/__manifest__.py Outdated Show resolved Hide resolved
@ioans73
Copy link
Member

ioans73 commented Apr 10, 2024

@chienandalu is it OK for you?

@chienandalu could you review this please?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-165-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5ad6f2e into OCA:16.0 Apr 10, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 06a9122. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@ioans73 ioans73 ioans73 approved these changes

@NICO-SOLUTIONS NICO-SOLUTIONS NICO-SOLUTIONS approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lef-adhoc @ioans73 @pedrobaeza @OCA-git-bot @NICO-SOLUTIONS @chienandalu @oca-travis @alvaro-domatix