Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] purchase_product_pack: Migration to 17.0 #171

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

antonyht27
Copy link

No description provided.

@antonyht27 antonyht27 force-pushed the 17.0-mig-purchase_product_pack branch 3 times, most recently from 5b6c260 to 31c2f69 Compare May 30, 2024 14:45
@antonyht27 antonyht27 mentioned this pull request May 30, 2024
5 tasks
@antonyht27 antonyht27 force-pushed the 17.0-mig-purchase_product_pack branch from 7c7d755 to a49aa9d Compare May 31, 2024 08:27
Copy link

@Michelle-RiveroM Michelle-RiveroM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% Functional

Copy link

@smcqueen81 smcqueen81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Functional

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@antonyht27
Copy link
Author

/ocabot migration purchase_product_pack

@OCA-git-bot
Copy link
Contributor

Sorry @antonyht27 you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@antonyht27 antonyht27 changed the title [MIG] purchase_product_pack: Migration to 17.0 [17.0][MIG] purchase_product_pack: Migration to 17.0 Jul 10, 2024
@sfealtec
Copy link

hello,
we test addon purchase_product_pack,

situation case :
product is a pack, sellable and buyable
on this pack 1x main supplier is set
on list of product pack, there are different suppliers (other component to complete product)

when create a purchase order,
all different component creates correct supplier order

but on the pack product,
this also add components provided by another supplier.
and if line is a variant product, variant information is lost.

best is to check purchase.order.partner_id is in product.product.seller_ids
and then write purchase order line

Can you agree to this request ?

@adriarrm
Copy link

Hello.

I just realized that the merge has not been done so that the purchase_product_pack module appears in version 17, even though everything seems to be OK.

Is there any problem with finishing the merge so that it can appear in the version 17 repository?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 16, 2025
@antonyht27
Copy link
Author

Hi @pedrobaeza any problems with this PR, do I need to change something?

@pedrobaeza
Copy link
Member

/ocabot migration purchase_product_pack

It requires a review of a PSC or maintainer. Right now I'm not able to do it, sorry.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants