[REF] x_product_pack: pricing refactor #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ernestotejeda, |
bruno-zanotti
force-pushed
the
17.0-t-33685-bz
branch
4 times, most recently
from
de9be6c
to
fe6885a
Compare
|
WIP: This PR is based on #174 so we need to merge it first |
bruno-zanotti
force-pushed
the
17.0-t-33685-bz
branch
2 times, most recently
from
124d006
to
b84ab77
Compare
bruno-zanotti
force-pushed
the
17.0-t-33685-bz
branch
3 times, most recently
from
9d6cd98
to
6bd0e02
Compare
bruno-zanotti
force-pushed
the
17.0-t-33685-bz
branch
2 times, most recently
from
7d92402
to
c8019da
Compare
|
Hello @pedrobaeza @FrancoMaxime @augusto-weiss @rousseldenis @ernestotejeda This PR is mainly a migration to v17 of #149. In Adhoc, we are already using it in our v17 clientes and everything seems to work fine. It is ready for review, but not for merge since depends on the migration of website_sale_product_pack #174 (I included in the firs commit so you can test it on runboat). It is an important fix / change so let's try to merge it ASAP, I tried to explain the change in the description and commits messages but if you have any doubt please let me know. |
This commit improves the way the price of the packs is computed to ensure it aligns with the behavior of normal products in Odoo. Key improvements include: 1. Refactor Pack Price Computation: Removed the inheritance from price_compute in favor of a clearer and more comprehensible _get_product_price method within the Pricelist class 2. 'get_price' -> '_get_pack_line_price': The get_price method on pack lines has been improved and renamed to _get_pack_line_price. It is now capable of returning the price of the pack line for a specified pricelist. 3. List Price Calculation: Enhanced the _compute_product_lst_price method to return the list price of a pack. It now leverages a new method analogous to price_compute, named _pack_line_price_compute, which can determine the prices of pack components, including nested packs.
Packs totalized and non-detailed ignores the product pack list price when computing the price. This commit is a hack to keep the behavior of the modules before this refactor. More information in the issue OCA#169.
Adapt the module sale_product_pack to the price refactor
Resolves an issue in the "Update Prices" action for packs. When update the pricelist, ignore all the "cero" lines, this is the components of packs "Detailed: Totalized in main product" or "Detailed - Ignored". We only want to update component lines if the parent pack is "Detailed - Detailed per component". Also keep in the so line the component discount settled in the parent pack settings. Steps to replicate the bug: 1. In a Sale Order add a product "Detailed - Detailed per component" 2. Save to see all the pack components 3. Change the pricelist to one with discount 4. Call the button action "Update Prices". Before this commit The price of the parent product gets updated, but the component prices remain unchanged. Even if the same product is added again (while retaining the first instance), the component prices show discrepancies. Now, when a pricelist with discounts is applied, all line items in the Sale Order including both parent and component products are updated accordingly.
bruno-zanotti
force-pushed
the
17.0-t-33685-bz
branch
from
c8019da
to
3636017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pricing refactor
This PR aims to perform a thorough refactor of the product_pack, sale_product_pack and website_sale_product_pack modules. The primary goal is to enhance the pricing logic for product packs, ensuring consistency and improved functionality.
Key improvements / fixes:
Refactor Pack Price Computation: Removed the inheritance from price_compute in favor of a clearer and
more comprehensible _get_product_price method within the Pricelist class
'get_price' -> '_get_pack_line_price': The get_price method on pack lines has been improved and renamed to _get_pack_line_price. It is now capable of returning the price of the pack line for a specified pricelist.
List Price Calculation: Enhanced the _compute_product_lst_price method to return the list price of a pack. It now leverages a new method analogous to price_compute, named _pack_line_price_compute, which can determine the prices of pack components, including nested packs.
Resolves an issue related to the action "Update Prices" on Sale Orders. Now when update the pricelist just take into account the components of packs "Detailed - Detailed per component" and ignore the rest. More info about how to replicate the bug in the commit message.
website Pack prices: show the correct price on the website.