Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_product_pack: Migration to 18.0 #193

Open
wants to merge 32 commits into
base: 18.0
Choose a base branch
from

Conversation

ALopez-Adhoc
Copy link

No description provided.

ernestotejeda and others added 30 commits November 25, 2024 12:39
Currently translated at 100.0% (1 of 1 strings)

Translation: product-pack-12.0/product-pack-12.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/pt/
Currently translated at 100.0% (1 of 1 strings)

Translation: product-pack-12.0/product-pack-12.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/fr/
…ines.

It seems to me that it would be if a user has the maximum stock permission, can edit the lines of packs, as well as a maximum sales permission.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-13.0/product-pack-13.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-stock_product_pack/
In v13 Odoo sets the stock at zero for products that are not services.
This commit will keep the stock of the services if they are packs,
to remain the functionality of the lasts versions.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/es/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-stock_product_pack branch 3 times, most recently from de113bd to c1c4706 Compare December 6, 2024 18:24
@augusto-weiss augusto-weiss force-pushed the 18.0-mig-stock_product_pack branch from c1c4706 to a042c04 Compare December 9, 2024 16:19
@augusto-weiss augusto-weiss mentioned this pull request Dec 9, 2024
4 tasks
Copy link

@nicolascol nicolascol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marielejeune
Copy link

Hi @ALopez-Adhoc , could you please remove the dependency to product_pack now that PR #189 is merged?

@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-stock_product_pack branch from a042c04 to 20fc1a4 Compare January 31, 2025 16:56
@ALopez-Adhoc
Copy link
Author

Hi @marielejeune. Done the removal. Ready to merge

Copy link

@matiasperalta1 matiasperalta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasperalta1
Copy link

@rousseldenis @pedrobaeza Could you merge it?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ALopez-Adhoc ALopez-Adhoc force-pushed the 18.0-mig-stock_product_pack branch from 20fc1a4 to dbecfd2 Compare February 6, 2025 12:30
@ALopez-Adhoc
Copy link
Author

Hi @pedrobaeza , all the requested changed were implemented and it is ready for one final review. Could you do it please? If ok, this pr is ready to merge

@pedrobaeza
Copy link
Member

/ocabot migration stock_product_pack

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 6, 2025
sub_qty = subproduct.quantity

for line in pack.pack_line_ids.filtered(
lambda p: p.product_id.type == "consu"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filter seems not correct. And why changing previous code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.