-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_product_pack: Migration to 18.0 #193
base: 18.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: product-pack-12.0/product-pack-12.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/pt/
Currently translated at 100.0% (1 of 1 strings) Translation: product-pack-12.0/product-pack-12.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/fr/
…ines. It seems to me that it would be if a user has the maximum stock permission, can edit the lines of packs, as well as a maximum sales permission.
…s if the product is storable.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-13.0/product-pack-13.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-stock_product_pack/
In v13 Odoo sets the stock at zero for products that are not services. This commit will keep the stock of the services if they are packs, to remain the functionality of the lasts versions.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/
Currently translated at 100.0% (5 of 5 strings) Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/es/
Currently translated at 100.0% (5 of 5 strings) Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
Currently translated at 100.0% (5 of 5 strings) Translation: product-pack-16.0/product-pack-16.0-stock_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
de113bd
to
c1c4706
Compare
c1c4706
to
a042c04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @ALopez-Adhoc , could you please remove the dependency to product_pack now that PR #189 is merged? |
a042c04
to
20fc1a4
Compare
Hi @marielejeune. Done the removal. Ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rousseldenis @pedrobaeza Could you merge it? |
This PR has the |
20fc1a4
to
dbecfd2
Compare
Hi @pedrobaeza , all the requested changed were implemented and it is ready for one final review. Could you do it please? If ok, this pr is ready to merge |
/ocabot migration stock_product_pack |
sub_qty = subproduct.quantity | ||
|
||
for line in pack.pack_line_ids.filtered( | ||
lambda p: p.product_id.type == "consu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter seems not correct. And why changing previous code?
No description provided.