[16.0][IMP] purchase vendor promotion follow up #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostelmo
force-pushed
the
16.0-imp-purchase_vendor_promotion_follow-up
branch
from
24da5ec to
9a762a4
Compare
santostelmo
changed the title
|
@cyrilmanuel @simahawk could you please followup with your reviews here ? |
santostelmo
force-pushed
the
16.0-imp-purchase_vendor_promotion_follow-up
branch
from
9a762a4 to
3a46650
Compare
simahawk
reviewed
Feb 14, 2025
| from odoo import Command | ||
| from odoo.exceptions import ValidationError | ||
| from odoo.tests import TransactionCase, tagged | ||
|
|
||
|
|
||
| @freeze_time("2024-01-02 03:21:34") |
There was a problem hiding this comment.
Decorating the class can give unexpected results, especially if a class is subclassed.
I always recommend to decorate the method or use the ctx manager where needed.
There was a problem hiding this comment.
As you a here... Can you use BaseCommon?
There was a problem hiding this comment.
BaseCommon
Decorating the class can give unexpected results, especially if a class is subclassed. I always recommend to decorate the method or use the ctx manager where needed.
I agree. Code updated
santostelmo
force-pushed
the
16.0-imp-purchase_vendor_promotion_follow-up
branch
from
3a46650 to
cfddc93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change
In replenishment, we think that assigning best supplier should also be the intended logical behavior the module.
This PR is a followup of #2321